fetcher: Support the new bazel HTTP headers format #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdclarke
reviewed
Oct 15, 2024
sdclarke
approved these changes
Oct 16, 2024
tomcoldrick-ct
approved these changes
Oct 21, 2024
|
Thanks for the patch! Looks good to me, but golint is unhappy about the format of the comments on the constants for the qualifiers, and wants |
|
Renamed consts. |
Bazel now sends qualifiers for each header in the form: http_header:<header>. We need to parse these out. Further, bazel also supports sending per-URI headers in cases where multiple URIs are sent. We can support this too.
|
Fixed comments. I have probably run golangci-lint first :( |
tomcoldrick-ct
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel now sends qualifiers for each header in the form:
http_header:<header>. We need to parse these out.Further, bazel also supports sending per-URI headers in cases where multiple URIs are sent. We can support this too.
Fixes #48