pass docker registry mirror info from executor to guest vm via MMDS #8389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bduffany
reviewed
Feb 12, 2025
dan-stowell
changed the title
vanja-p
reviewed
Feb 14, 2025
enterprise/server/remote_execution/containers/firecracker/firecracker.go
Outdated
Show resolved
Hide resolved
enterprise/server/remote_execution/containers/firecracker/firecracker.go
Outdated
Show resolved
Hide resolved
enterprise/server/remote_execution/containers/firecracker/firecracker.go
Outdated
Show resolved
Hide resolved
maggie-lou
reviewed
Feb 14, 2025
| @@ -1452,6 +1458,7 @@ func (c *FirecrackerContainer) getConfig(ctx context.Context, rootFS, containerF | |||
| HostDevName: tapDeviceName, | |||
| MacAddress: tapDeviceMac, | |||
| }, | |||
| AllowMMDS: c.vmConfig.InitDockerd, | |||
There was a problem hiding this comment.
Why unused? I think setting AllowMMDS to true causes the MMDS configuration handler to run during init.
enterprise/server/remote_execution/containers/firecracker/firecracker.go
Outdated
Show resolved
Hide resolved
bduffany
approved these changes
Feb 14, 2025
enterprise/server/remote_execution/containers/firecracker/firecracker.go
Show resolved
Hide resolved
enterprise/server/remote_execution/containers/firecracker/firecracker.go
Outdated
Show resolved
Hide resolved
enterprise/server/remote_execution/containers/firecracker/firecracker.go
Show resolved
Hide resolved
…cracker.go Co-authored-by: Brandon Duffany <[email protected]>
…cracker.go Co-authored-by: Brandon Duffany <[email protected]>
Co-authored-by: Brandon Duffany <[email protected]>
Co-authored-by: Brandon Duffany <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to be able to have
dockerdrunning inside a Firecracker VM be able to pull images from registry mirrors (and, for tests, be able to pull from insecure registries).This change introduces
executor.firecracker_vm_docker_mirrorsandexecutor.firecracker_vm_docker_insecure_registriesflags. When either is set, the host machine writes their values as JSON and passes that JSON to the VM over the microVM Metadata Service, also known as the Firecracker Metadata API or MMDS.This change bumps the Firecracker guest API version. I'm not sure if that bump is strictly necessary or warranted.