Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename variables, fields, and functions named Option to OptionDefinition as appropriate in cli parser #8596

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tempoz
Copy link
Contributor

@tempoz tempoz commented Mar 10, 2025

To avoid naming collisions when introducing the Option struct as a parsed form of an option from the command line, make all of the naming in parser.go consistent.

@tempoz tempoz requested a review from bduffany March 10, 2025 18:58
Copy link
Member

@bduffany bduffany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe s/Definition/Schema/g - a little more concise & convenient while still clear?

@tempoz
Copy link
Contributor Author

tempoz commented Mar 10, 2025

I talked with Fabian and he recommended Definition instead of Schema for consistency with the verbiage used by bazel.

@bduffany
Copy link
Member

@tempoz sgtm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants