-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC003 AL01 - improving documentation #75
Open
pjanck
wants to merge
9
commits into
buildingSMART:main
Choose a base branch
from
bSI-RailwayRoom:bc003-al01
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
effae84
following #41, committing in the name of @joaoguilhermecorrea - BC003…
pjanck 82b510a
Linking to existing requirements
39a02db
Adding ALB004 to the 'Syntax & schema checks'
sylvainmarie 580d064
Moving ALB004 to the more generic section
sylvainmarie 70e6fa7
Adding requirements and selected entities to implement the test plan
7ff299b
CT for IfcRelPositions
eb9cba6
Merge remote-tracking branch 'upstream/main' into bc003-al01
pjanck fcabdf8
indenting ids
pjanck 113382b
minor correction to the readme
pjanck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,121 @@ | ||
<?xml version="1.0" encoding="UTF-8" standalone="yes"?><ids:ids xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://standards.buildingsmart.org/IDS ids_09.xsd" xmlns:ids="http://standards.buildingsmart.org/IDS"><!--edited with usBIM.IDSeditor (http://www.accasoftware.com)--><ids:info><ids:title>BC003_PS01</ids:title><ids:description>This file was produced for aIFC4Rail project.</ids:description><ids:author>[email protected]</ids:author><ids:date>2023-05-31</ids:date><ids:purpose>to verify BC003 PS01 test requirements</ids:purpose></ids:info><ids:specifications><ids:specification ifcVersion="IFC4X3" name="IfcProject" minOccurs="1" maxOccurs="1" identifier="01" description="This test verifies the following requirement:
-There must be 1 instance of IfcProject and must be named BC003: Test plan 1" instructions="The IFCPROJECT's name must be set as "BC003: Test plan 1" to pass the test."><ids:applicability><ids:entity><ids:name><ids:simpleValue>IFCPROJECT</ids:simpleValue></ids:name></ids:entity></ids:applicability><ids:requirements><ids:attribute minOccurs="1" maxOccurs="1"><ids:name><ids:simpleValue>Name</ids:simpleValue></ids:name><ids:value><ids:simpleValue>BC003: Test plan 1</ids:simpleValue></ids:value></ids:attribute></ids:requirements></ids:specification><ids:specification ifcVersion="IFC4X3" name="IfcSIUnit - Length unit" minOccurs="1" maxOccurs="unbounded" identifier="02" description="This test verifies the following requirement:
• There must be at least 1 instance of IfcSIUnit assigning Metre as default unit for length
" instructions="Project measure units must be set as metric."><ids:applicability><ids:entity><ids:name><ids:simpleValue>IFCSIUNIT</ids:simpleValue></ids:name></ids:entity><ids:attribute><ids:name><ids:simpleValue>UnitType</ids:simpleValue></ids:name><ids:value><ids:simpleValue>.LENGTHUNIT.</ids:simpleValue></ids:value></ids:attribute></ids:applicability><ids:requirements><ids:attribute minOccurs="1" maxOccurs="1"><ids:name><ids:simpleValue>Name</ids:simpleValue></ids:name><ids:value><ids:simpleValue>.METRE.</ids:simpleValue></ids:value></ids:attribute></ids:requirements></ids:specification><ids:specification ifcVersion="IFC4X3" name="IfcSIUnit - Angle unit" minOccurs="1" maxOccurs="unbounded" identifier="03" description="This test verifies the following requirement:
• There must be at least 1 instance of IfcSIUnit assigning Radian as default unit for plane angle

" instructions="Project measure units must be set as metric."><ids:applicability><ids:entity><ids:name><ids:simpleValue>IFCSIUNIT</ids:simpleValue></ids:name></ids:entity><ids:attribute><ids:name><ids:simpleValue>UnitType</ids:simpleValue></ids:name><ids:value><ids:simpleValue>.PLANEANGLEUNIT.</ids:simpleValue></ids:value></ids:attribute></ids:applicability><ids:requirements><ids:attribute minOccurs="1" maxOccurs="1"><ids:name><ids:simpleValue>Name</ids:simpleValue></ids:name><ids:value><ids:simpleValue>.RADIAN.</ids:simpleValue></ids:value></ids:attribute></ids:requirements></ids:specification><ids:specification ifcVersion="IFC4X3" name="Coordinate reference system" minOccurs="1" maxOccurs="unbounded" identifier="04" description="This test verifies the following requirement:
- Georeferencing of the project shall be assigned as RGF Lambert Zone 3 (EPSG:3944) 
" instructions="Coordinate system must be set as RGF93 Lambert Zone 3 (EPSG:3944)"><ids:applicability><ids:entity><ids:name><ids:simpleValue>IFCPROJECTEDCRS</ids:simpleValue></ids:name></ids:entity></ids:applicability><ids:requirements><ids:attribute minOccurs="1" maxOccurs="1"><ids:name><ids:simpleValue>Name</ids:simpleValue></ids:name><ids:value><ids:simpleValue>EPSG:3944</ids:simpleValue></ids:value></ids:attribute><ids:attribute minOccurs="1" maxOccurs="1"><ids:name><ids:simpleValue>GeodeticDatum</ids:simpleValue></ids:name><ids:value><ids:simpleValue>RGF93</ids:simpleValue></ids:value></ids:attribute></ids:requirements></ids:specification></ids:specifications></ids:ids> | ||
<?xml version="1.0" encoding="UTF-8" standalone="yes"?> | ||
<ids:ids xmlns:ids="http://standards.buildingsmart.org/IDS" xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://standards.buildingsmart.org/IDS ids_09.xsd"> | ||
<!--edited with usBIM.IDSeditor (http://www.accasoftware.com)--> | ||
<ids:info> | ||
<ids:title>BC003_PS01</ids:title> | ||
<ids:description>This file was produced for aIFC4Rail project.</ids:description> | ||
<ids:author>[email protected]</ids:author> | ||
<ids:date>2023-05-31</ids:date> | ||
<ids:purpose>to verify BC003 PS01 test requirements</ids:purpose> | ||
</ids:info> | ||
<ids:specifications> | ||
<ids:specification description="This test verifies the following requirement: | ||
-There must be 1 instance of IfcProject and must be named BC003: Test plan 1" identifier="01" ifcVersion="IFC4X3" instructions="The IFCPROJECT's name must be set as "BC003: Test plan 1" to pass the test." maxOccurs="1" minOccurs="1" name="IfcProject"> | ||
<ids:applicability> | ||
<ids:entity> | ||
<ids:name> | ||
<ids:simpleValue>IFCPROJECT</ids:simpleValue> | ||
</ids:name> | ||
</ids:entity> | ||
</ids:applicability> | ||
<ids:requirements> | ||
<ids:attribute maxOccurs="1" minOccurs="1"> | ||
<ids:name> | ||
<ids:simpleValue>Name</ids:simpleValue> | ||
</ids:name> | ||
<ids:value> | ||
<ids:simpleValue>BC003: Test plan 1</ids:simpleValue> | ||
</ids:value> | ||
</ids:attribute> | ||
</ids:requirements> | ||
</ids:specification> | ||
<ids:specification description="This test verifies the following requirement: | ||
• There must be at least 1 instance of IfcSIUnit assigning Metre as default unit for length | ||
" identifier="02" ifcVersion="IFC4X3" instructions="Project measure units must be set as metric." maxOccurs="unbounded" minOccurs="1" name="IfcSIUnit - Length unit"> | ||
<ids:applicability> | ||
<ids:entity> | ||
<ids:name> | ||
<ids:simpleValue>IFCSIUNIT</ids:simpleValue> | ||
</ids:name> | ||
</ids:entity> | ||
<ids:attribute> | ||
<ids:name> | ||
<ids:simpleValue>UnitType</ids:simpleValue> | ||
</ids:name> | ||
<ids:value> | ||
<ids:simpleValue>.LENGTHUNIT.</ids:simpleValue> | ||
</ids:value> | ||
</ids:attribute> | ||
</ids:applicability> | ||
<ids:requirements> | ||
<ids:attribute maxOccurs="1" minOccurs="1"> | ||
<ids:name> | ||
<ids:simpleValue>Name</ids:simpleValue> | ||
</ids:name> | ||
<ids:value> | ||
<ids:simpleValue>.METRE.</ids:simpleValue> | ||
</ids:value> | ||
</ids:attribute> | ||
</ids:requirements> | ||
</ids:specification> | ||
<ids:specification description="This test verifies the following requirement: | ||
• There must be at least 1 instance of IfcSIUnit assigning Radian as default unit for plane angle | ||
|
||
" identifier="03" ifcVersion="IFC4X3" instructions="Project measure units must be set as metric." maxOccurs="unbounded" minOccurs="1" name="IfcSIUnit - Angle unit"> | ||
<ids:applicability> | ||
<ids:entity> | ||
<ids:name> | ||
<ids:simpleValue>IFCSIUNIT</ids:simpleValue> | ||
</ids:name> | ||
</ids:entity> | ||
<ids:attribute> | ||
<ids:name> | ||
<ids:simpleValue>UnitType</ids:simpleValue> | ||
</ids:name> | ||
<ids:value> | ||
<ids:simpleValue>.PLANEANGLEUNIT.</ids:simpleValue> | ||
</ids:value> | ||
</ids:attribute> | ||
</ids:applicability> | ||
<ids:requirements> | ||
<ids:attribute maxOccurs="1" minOccurs="1"> | ||
<ids:name> | ||
<ids:simpleValue>Name</ids:simpleValue> | ||
</ids:name> | ||
<ids:value> | ||
<ids:simpleValue>.RADIAN.</ids:simpleValue> | ||
</ids:value> | ||
</ids:attribute> | ||
</ids:requirements> | ||
</ids:specification> | ||
<ids:specification description="This test verifies the following requirement: | ||
- Georeferencing of the project shall be assigned as RGF Lambert Zone 3 (EPSG:3944) | ||
" identifier="04" ifcVersion="IFC4X3" instructions="Coordinate system must be set as RGF93 Lambert Zone 3 (EPSG:3944)" maxOccurs="unbounded" minOccurs="1" name="Coordinate reference system"> | ||
<ids:applicability> | ||
<ids:entity> | ||
<ids:name> | ||
<ids:simpleValue>IFCPROJECTEDCRS</ids:simpleValue> | ||
</ids:name> | ||
</ids:entity> | ||
</ids:applicability> | ||
<ids:requirements> | ||
<ids:attribute maxOccurs="1" minOccurs="1"> | ||
<ids:name> | ||
<ids:simpleValue>Name</ids:simpleValue> | ||
</ids:name> | ||
<ids:value> | ||
<ids:simpleValue>EPSG:3944</ids:simpleValue> | ||
</ids:value> | ||
</ids:attribute> | ||
<ids:attribute maxOccurs="1" minOccurs="1"> | ||
<ids:name> | ||
<ids:simpleValue>GeodeticDatum</ids:simpleValue> | ||
</ids:name> | ||
<ids:value> | ||
<ids:simpleValue>RGF93</ids:simpleValue> | ||
</ids:value> | ||
</ids:attribute> | ||
</ids:requirements> | ||
</ids:specification> | ||
</ids:specifications> | ||
</ids:ids> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,10 +22,15 @@ The series of tests that belong to this Business Case are listed as follows: | |
| ALX4 | Stationing tests on cable joints (punctual) | | ||
| NE02 | Cable routing | | ||
|
||
## IFC concepts involved in this test | ||
|
||
The following diagram represents the entities involved in this test. | ||
![AL01 - involved entities](./BC003_AL01_diagram.png) | ||
|
||
|
||
## Prerequisites | ||
|
||
None. | ||
PS01 as indicated above. | ||
|
||
## Test dataset (input) | ||
|
||
|
@@ -120,5 +125,14 @@ After importing the reference file (`BC003_AL01_alignments.xml`): | |
|
||
## Link to requirements | ||
|
||
:zap: | ||
|
||
|ID (local) | Name | Description | Requirements for Appointed Party | | ||
|-|-|-|-| | ||
| RI 86 | Unique containment | "Each IfcElement shall be either: - contained in one and only one IfcSpatialStructureElement, or - contained in one and only one IfcLinearPositioningElement." | RA-75 | | ||
| RI 305 | Alignment organization | CableCarrier alignments shall be related to the track alignment with IfcRelPositions relationship | Cable carrier alignments shall be related to the track alignment | | ||
| RI 311 | Alignement extruded geometry placement | A IfcCableCarrierSement which geometry is a IfcSectionSolidHorizontal shall be using the same IfcObjectPlacement as the IfcAlignment it is positioned along | NIL| | ||
| RI 312 | Offset alignment placement | An IfcAlignment which geometry is a IfcOffsetCurveByDistances shall use the same IfcLocalPlacement as the IfcAlignment is relates to | NIL| | ||
| RI 313 | Extruded CableCarrier positioning | A IfcSectionedSolidHorizontal geometry used for a IfcCableCarrierElement positioned relatively from an IfcAlignment shall use its IfcLocalPlacement | NIL | | ||
| RI 314 | Project structure | The only "container" aggregated to the project shall be either IfcSite, IfcFacility, IfcAlignment. Other non-IfcProducts shall be connected to the project with IfcRelDeclares | NIL | | ||
| RI 315 | Elements referencing in Spatial structures | If IfcElements are positioned wrt IfcPositioning elements, then they must be also referenced (instead of aggregated) into a IfcSpatialStructure element | NIL | | ||
Comment on lines
+131
to
+137
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Please see here. |
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diagram is adding requirements on the use of IfcRelPositions that are not further documented within the test instructions, nor in the IFC specification (e.g., between two alignments, between an alignment and a spatial structure element). Please clarify the requirements, possibly referring to existing IFC documentation.