-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC003 ALX3b - Initial PR #79
Open
pjanck
wants to merge
5
commits into
buildingSMART:main
Choose a base branch
from
bSI-RailwayRoom:BC003_ALX3b
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,101 @@ | ||
# 5 Stationing tests on nodes - BC003-ALX3b | ||
|
||
| Test code | Test author | Test dataset source | Test direction | | ||
|------------|-----------------|---------------------|----------------| | ||
|BC003-ALX3b | Joao Correa | MINnD | Import/Export | | ||
|
||
|
||
## Intent | ||
|
||
This Test belongs to a series of Tests that share a dataset from the same project as a business case. | ||
The series of tests that belong to this Business Case are listed as follows: | ||
|
||
| Test code | Test name | | ||
|-----------|-----------------| | ||
| PS01 | Project setup with georeferencing | | ||
| AL01 | Multiple alignments of railway line | | ||
| RR01 | Railway track elements validation | | ||
| ALX1 | Stationing tests on equipment (punctual)| | ||
| ALX2 | Stationing tests on nodes (punctual) | | ||
| ALX3a | Alignment reference check on linear elements (early design) | | ||
| **ALX3b** | **Alignment reference check on linear elements (detailed design, precast)** | | ||
| ALX3c | Alignment reference check on linear elements (detailed design, case-in-place) | | ||
| NE01 | Network integrity/continuity check on linear elements | | ||
| ALX4 | Stationing tests on cable joints (punctual) | | ||
| NE02 | Cable routing | | ||
|
||
## IFC concepts involved in this test | ||
|
||
The following test intends to address the use case where the cable infrastructure is made of pre-cast concrete elements, following its own aligment, related to the tracks: | ||
![ALX3b - cabling infrastructure, precast](./BC003_ALX3b_cabling_infrastructure_precast.jpg) | ||
|
||
The following diagram represents the rationale used for this test: the cabling supporting structure follows the track alignment but on a separate alignment, represented by a polyline. | ||
![ALX3b - rationale](./BC003-ALX3b_rationale.png) | ||
|
||
The cabling supporting structure is represented by a swept volume using the following 2D profile: | ||
![ALX3b - 2D profile](./BC003-ALX3b_2Dprofile.png) | ||
|
||
|
||
The following diagram represents the entities involved in this test. | ||
![ALX3b - involved entities](./BC003_ALX3b_diagram.png) | ||
|
||
## Prerequisites | ||
|
||
The test plan builds upon the previous test plans. All requirements presented in previous test plans must be met. | ||
|
||
## Test dataset (input) | ||
|
||
This test case utilises the dataset collected in the Dataset folder and is summarised in the table below. **For more details on each item see [Dataset description](Dataset/README.md).** | ||
|
||
|
||
In addition, the outcome of the previous tests shall be used as input of this test. | ||
|
||
## Validation criteria | ||
|
||
:zap: For this test case to be considered passed, **all criteria listed in this section**, and **the ones of prerequisites tests** shall be verified. :zap: | ||
|
||
### Formal rules | ||
|
||
#### IFC standard (schema and specification) | ||
|
||
When validated using the bSI Validation Service, the IFC must pass: | ||
|
||
- Syntax & Schema check | ||
|
||
|
||
#### Test case-specific checks | ||
|
||
:hourglass: | ||
|
||
#### Not covered by the IDS file (must be checked otherwise): | ||
|
||
:hourglass: | ||
|
||
### Informal criteria | ||
|
||
- The precast elements are defined in a `DistributionFlowElementType` | ||
- The precast elements geometries are mapped, in order to avoid geometry duplication | ||
|
||
Open questions: | ||
- Should we use some `IfcRelNests` relationship between Alignments? | ||
- Some Concept Template seems required in order use `IfcRelPositions` to link the cable carrier to the alignment? | ||
- The cable carrier needs to be spatially contained in the IfcRailway, but is located w.r.t. some alignment. Does it introduce some potential inconstistancy? | ||
|
||
### Control parameters | ||
|
||
The following steps should be performed in order to corroborate that the software is working as expected. | ||
|
||
:hourglass: | ||
|
||
## Open questions | ||
|
||
The semantic link between the cabling infrastructure alignment and the track alignment is rather weak (ie. it is contained in the Railway spatial structure which is positioned on the track alignment). How would a software offer a proper UX for navigation between the two alignments? More relationships could be used to link the two alignments? | ||
|
||
## Link to requirements | ||
|
||
|ID (local) | Name | Description | Requirements for Appointed Party | | ||
|-|-|-|-| | ||
| RI 5 | Alignment shape representation in IFC | "IfcAlignment shall use ‘Axis’ as representation identifier, ‘Curve3D’ as representation type, and can use IfcGradientCurve (if only horizontal and vertical layouts are available), IfcSegmentedReferenceCurve (if cant is available), IfcCompositeCurve (if only horizontal is available). For some cases when alignment segments are defined as point list, IfcIndexedPolycurve can also be used." | RA-3 | | ||
| RI 86 | Unique containment | "Each IfcElement shall be either: - contained in one and only one IfcSpatialStructureElement, or - contained in one and only one IfcLinearPositioningElement." | RA-75 | | ||
| RI 300 | Signals reused geometries | Signal parts geometries shall be mapped (IfcMappedItem) to their matching type geometry | Every signal sharing the same type shall reuse shared geometry defined for the signal type | | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as #75 (comment)