perf: improve performance of switching schemes (#687)

* perf: improve performance of switching schemes * move to new section
built-on-openfin · Feb 19, 2024 · 1231b4f · 1231b4f
1 parent 5d19b06
commit 1231b4f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/how-to/workspace-platform-starter/CHANGELOG.md b/how-to/workspace-platform-starter/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## v17.2.0
 
+- Improved performance of switching schemes
+
+## v17.0.0
+
 - Added support for dock submenus
 - Added support for customizing the taskbar icon for the splash screen window
 - Added an example of navigating content using navigation controls. Enabled through default window options in the main [manifest.fin.json](./public/manifest.fin.json) and in our developer docs snapshot [developer.snapshot.fin.json](./public/common/snapshots/developer.snapshot.fin.json)

diff --git a/how-to/workspace-platform-starter/client/src/framework/platform/platform-override.ts b/how-to/workspace-platform-starter/client/src/framework/platform/platform-override.ts
@@ -824,9 +824,7 @@ export function overrideCallback(
 		 */
 		public async setSelectedScheme(schemeType: ColorSchemeOptionType): Promise<void> {
 			// The color scheme has been updated, so update the theme
-			await setCurrentColorSchemeMode(schemeType);
-
-			return super.setSelectedScheme(schemeType);
+			await Promise.all([setCurrentColorSchemeMode(schemeType), super.setSelectedScheme(schemeType)]);
 		}
 
 		/**