Skip to content

Commit

Permalink
Update dock example
Browse files Browse the repository at this point in the history
The new buttons resulted in window scroll bars so the window size was increased.

The enable disable buttons did not take into account whether or not a dock was registered.
  • Loading branch information
johnman committed Jan 22, 2024
1 parent bdc53f1 commit 4cdea77
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
4 changes: 4 additions & 0 deletions how-to/register-with-dock-basic/client/src/provider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,8 @@ function setStates(isRegistered: boolean | null): void {
deregisterButton &&
showButton &&
minimizeButton &&
enableButton &&
disableButton &&
showHomeButton &&
showNotificationButton &&
showStorefrontButton &&
Expand All @@ -202,6 +204,8 @@ function setStates(isRegistered: boolean | null): void {
deregisterButton.disabled = isRegistered === null || !isRegistered;
showButton.disabled = isRegistered === null || !isRegistered;
minimizeButton.disabled = isRegistered === null || !isRegistered;
enableButton.disabled = isRegistered === null || !isRegistered;
disableButton.disabled = isRegistered === null || !isRegistered;
showHomeButton.disabled = isRegistered === null || isRegistered;
showNotificationButton.disabled = isRegistered === null || isRegistered;
showStorefrontButton.disabled = isRegistered === null || isRegistered;
Expand Down
4 changes: 3 additions & 1 deletion how-to/register-with-dock-basic/public/manifest.fin.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@
"icon": "http://localhost:8080/favicon.ico",
"autoShow": true,
"providerUrl": "http://localhost:8080/platform/provider.html",
"preventQuitOnLastWindowClosed": true
"preventQuitOnLastWindowClosed": true,
"minWidth": 750,
"defaultWidth": 750
},
"shortcut": {
"company": "OpenFin",
Expand Down

0 comments on commit 4cdea77

Please sign in to comment.