Skip to content

Commit

Permalink
19.1.0 BugFix
Browse files Browse the repository at this point in the history
Fixed the launch snapshot logic when multiple pages exist within a window. Layout mapping was being applied at the wrong level which prevented the snapshot from being applied.
  • Loading branch information
johnman committed Oct 16, 2024
1 parent 9436d88 commit 5b7d5e6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions how-to/workspace-platform-starter/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
- Updated integration template that is used when you use npm run generate-module integrations "Your Integration" so that it includes example results and examples of handling result clicks so that you have an easier starting point.
- Updated example-notification-source so that you can specify a url to post notifications to (it will wrap the request in a message property and send it to the server you specify via post: { url: "" } settings. Our example node-starter supports messages being posted to <http://localhost:6060/api/messages>.
- Updated the notification service example app so that if you select the endpoint example action it will post a notification to the notification source create endpoint.
- BUGFIX - Updated Snapshot launching logic as there was a bug when updating a page's layout (to ensure view names are regenerated when using app naming conventions) in a multi page window which resulted in the page layout being assigned at the wrong level.

## v19.0.0

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -790,8 +790,10 @@ async function launchSnapshot(snapshotApp: PlatformApp): Promise<PlatformAppIden
for (const currentWindow of windows) {
if (Array.isArray(currentWindow.workspacePlatform?.pages)) {
for (let i = 0; i < currentWindow.workspacePlatform.pages.length; i++) {
let page = currentWindow.workspacePlatform.pages[i];
page = updateInstanceIds(page.layout);
const page = currentWindow.workspacePlatform.pages[i];
if (!isEmpty(page.layout)) {
page.layout = updateInstanceIds(page.layout);
}
currentWindow.workspacePlatform.pages[i] = page;
}
} else {
Expand Down

0 comments on commit 5b7d5e6

Please sign in to comment.