Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(splash screen) add taskbarIcon property for splash screen window #673

Merged
merged 2 commits into from
Jan 24, 2024
Merged

feat(splash screen) add taskbarIcon property for splash screen window #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e73fd8c
feat(splash screen) add `taskbarIcon` property for splash screen window
camc314 Jan 22, 2024
7e66ea2
Merge branch 'workspace/vnext' into c/splash-screen-icon
johnman Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions how-to/workspace-platform-starter/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## v17.0.0

- Added support for dock submenus
- Added support for customizing the taskbar icon for the splash screen window

## v16.1.0

Expand Down
1 change: 1 addition & 0 deletions how-to/workspace-platform-starter/client/src/framework/platform/platform-splash.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ export async function open(): Promise<void> {
resizable: false,
saveWindowState: false,
showTaskbarIcon: true,
icon: customSettings?.splashScreenProvider?.taskbarIcon ?? icon,
customData: {
channelName,
style: {
Expand Down
5 changes: 5 additions & 0 deletions how-to/workspace-platform-starter/client/src/framework/shapes/splash-shapes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,9 @@ export interface SplashScreenProviderOptions {
* The border color, defaults to theme border.
*/
borderColor?: string;

/**
* The taskbar icon. Falls back to icon if not provided.
*/
taskbarIcon?: string;
camc314 marked this conversation as resolved.
Show resolved Hide resolved
}
4 changes: 4 additions & 0 deletions how-to/workspace-platform-starter/client/types/module/shapes/splash-shapes.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,8 @@ export interface SplashScreenProviderOptions {
* The border color, defaults to theme border.
*/
borderColor?: string;
/**
* The taskbar icon. Falls back to icon if not provided.
*/
taskbarIcon?: string;
}
4 changes: 4 additions & 0 deletions how-to/workspace-platform-starter/public/schemas/settings.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4180,6 +4180,10 @@
"description": "This defaults to manifest.platform.icon if not provided.",
"type": "string"
},
"taskbarIcon": {
"description": "The taskbar icon. Falls back to icon if not provided.",
"type": "string"
},
"textColor": {
"description": "The text color, defaults to theme text.",
"type": "string"
Expand Down
4 changes: 4 additions & 0 deletions how-to/workspace-platform-starter/public/schemas/wps.manifest.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4172,6 +4172,10 @@
"description": "This defaults to manifest.platform.icon if not provided.",
"type": "string"
},
"taskbarIcon": {
"description": "The taskbar icon. Falls back to icon if not provided.",
"type": "string"
},
"textColor": {
"description": "The text color, defaults to theme text.",
"type": "string"
Expand Down
Loading