Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use allSettled instead of all such that fireLifecycleEvent doesn't throw #683

Open
wants to merge 1 commit into
base: workspace/v17.0.0
Choose a base branch
from
Open

fix: use allSettled instead of all such that fireLifecycleEvent doesn't throw #683

wants to merge 1 commit into from

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Feb 12, 2024

If any of the lifecycle event listeners throw, this will cause fireLifecyleEvent to throw. This is undesirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeransegnola joeransegnola joeransegnola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camc314 @joeransegnola