Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional action for a workspace lifecycle event. #703

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

johnman
Copy link
Member

@johnman johnman commented Apr 10, 2024

Added an extra action to make it clear when a workspace was applied. Updated impacted modules.

  • Improvement: Added apply as an action on the WorkspaceChangedLifecyclePayload. Previously we had create, update, delete. update was being fired when a workspace was updated and when a workspace was applied. apply now makes it clear when a particular workspace platform override has been triggered.
  • Improvement: modules/integrations/workspaces this module now refreshes the entries when a workspace is applied. So if a workspace entry in Home said it was selected it would be updated and the newly selected workspace would be updated to reflect it is the currently selected workspace.
  • Updated: modules/composite/default-workspace/lifecycle logic to listen out for the new apply action.

Added an extra action to make it clear when a workspace was applied. Updated impacted modules.
@johnman johnman merged commit eccfe0b into workspace/v18.0.0 Apr 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants