Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial change to contacts page #734

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

joeransegnola
Copy link
Member

John, put in the URL detection here. I'm a bit perplexed on how to test it. I've tried opening it in chrome, but the shim.js fin load errors out before the page scripts load. And, when trying it out from a new tab in WPS, it looks like the URL just doesn't load at all, which seems strange.

@joeransegnola joeransegnola requested a review from johnman July 22, 2024 22:04
Copy link
Member

@johnman johnman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it locally and it works. I will send you a loom so you can test and confirm for yourself before merging in.

@joeransegnola joeransegnola merged commit 3403529 into main Jul 25, 2024
5 checks passed
@joeransegnola joeransegnola deleted the dev/joe/contacts-url-detection branch July 25, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants