Remove derivedStateOf

bumble-tech · Sep 8, 2023 · a157af2 · a157af2
1 parent 2146038
commit a157af2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 22 deletions.
diff --git a/...ions/common/src/commonMain/kotlin/com/bumble/appyx/interactions/core/DraggableChildren.kt b/...ions/common/src/commonMain/kotlin/com/bumble/appyx/interactions/core/DraggableChildren.kt
@@ -10,7 +10,6 @@ import androidx.compose.runtime.Composable
 import androidx.compose.runtime.CompositionLocalProvider
 import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.collectAsState
-import androidx.compose.runtime.derivedStateOf
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.key
 import androidx.compose.runtime.mutableStateOf
@@ -190,16 +189,13 @@ fun elementOffset(
     val positionOutside = motionPropertyRenderValue<PositionOutside.Value, PositionOutside>()
     val layoutDirection = LocalLayoutDirection.current
 
-    val positionInsideOffset by derivedStateOf {
-        positionInside?.let {
-            it.alignment.align(elementSize, containerSize, layoutDirection)
-        } ?: IntOffset.Zero
-    }
-    val positionOutsideOffset by derivedStateOf {
-        positionOutside?.let {
-            it.alignment.align(elementSize, containerSize, layoutDirection)
-        } ?: IntOffset.Zero
-    }
+    val positionInsideOffset = positionInside?.let {
+        it.alignment.align(elementSize, containerSize, layoutDirection)
+    } ?: IntOffset.Zero
+
+    val positionOutsideOffset = positionOutside?.let {
+        it.alignment.align(elementSize, containerSize, layoutDirection)
+    } ?: IntOffset.Zero
 
     return positionInsideOffset - positionOutsideOffset
 }
diff --git a/...ion/common/src/commonMain/kotlin/com/bumble/appyx/navigation/composable/AppyxComponent.kt b/...ion/common/src/commonMain/kotlin/com/bumble/appyx/navigation/composable/AppyxComponent.kt
@@ -7,7 +7,6 @@ import androidx.compose.runtime.Composable
 import androidx.compose.runtime.CompositionLocalProvider
 import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.collectAsState
-import androidx.compose.runtime.derivedStateOf
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.key
 import androidx.compose.runtime.mutableStateOf
@@ -218,16 +217,13 @@ class ChildrenTransitionScope<InteractionTarget : Any, NavState : Any>(
         val positionOutside = motionPropertyRenderValue<PositionOutside.Value, PositionOutside>()
         val layoutDirection = LocalLayoutDirection.current
 
-        val positionInsideOffset by derivedStateOf {
-            positionInside?.let {
-                it.alignment.align(elementSize, containerSize, layoutDirection)
-            } ?: IntOffset.Zero
-        }
-        val positionOutsideOffset by derivedStateOf {
-            positionOutside?.let {
-                it.alignment.align(elementSize, containerSize, layoutDirection)
-            } ?: IntOffset.Zero
-        }
+        val positionInsideOffset = positionInside?.let {
+            it.alignment.align(elementSize, containerSize, layoutDirection)
+        } ?: IntOffset.Zero
+
+        val positionOutsideOffset = positionOutside?.let {
+            it.alignment.align(elementSize, containerSize, layoutDirection)
+        } ?: IntOffset.Zero
 
         return positionInsideOffset + positionOutsideOffset
     }