Merge pull request #588 from zsoltk/fix-bounds-on-readd

Set bounds on all new motion controllers
bumble-tech · Sep 12, 2023 · e44deb5 · e44deb5
2 parents cf7a88b + 82a9927
commit e44deb5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,12 +8,13 @@
 
 
 ### Fixed
-- 
-- [#589](https://github.com/bumble-tech/appyx/pull/589) – Fix visibility resolution for elements that do not match parent's size
-- [#586](https://github.com/bumble-tech/appyx/issues/586) – Fix `AppyxComponent` wrongly applying width and height modifier to children composables
+
 - [#584](https://github.com/bumble-tech/appyx/pull/584) – Fix applying offset twice in `AppyxComponent`
 - [#585](https://github.com/bumble-tech/appyx/pull/585) – Fix drag vs align
 - [#571](https://github.com/bumble-tech/appyx/pull/571) – Avoid `MotionController` recreation
+- [#587](https://github.com/bumble-tech/appyx/pull/587) – Fix `DraggableChildren` and rename it to `AppyxComponent`
+- [#588](https://github.com/bumble-tech/appyx/pull/588) – Set bounds on all new motion controllers
+- [#589](https://github.com/bumble-tech/appyx/pull/589) – Fix visibility resolution for elements that do not match parent's size
 
 
 ## 2.0.0-alpha04

diff --git a/...mmon/src/commonMain/kotlin/com/bumble/appyx/interactions/core/model/BaseAppyxComponent.kt b/...mmon/src/commonMain/kotlin/com/bumble/appyx/interactions/core/model/BaseAppyxComponent.kt
@@ -183,6 +183,7 @@ open class BaseAppyxComponent<InteractionTarget : Any, ModelState : Any>(
     }
 
     private fun onMotionControllerReady(motionController: MotionController<InteractionTarget, ModelState>) {
+        motionController.updateBounds(transitionBounds)
         observeAnimationChanges(motionController)
         observeMotionController(motionController)
     }