Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated AGP to 8.1.1 #578

Merged
merged 3 commits into from
Sep 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: '11'
java-version: '17'
- uses: gradle/wrapper-validation-action@v1
- uses: gradle/gradle-build-action@v2
with:
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: '11'
java-version: '17'
- uses: gradle/wrapper-validation-action@v1
- uses: gradle/gradle-build-action@v2
with:
Expand Down Expand Up @@ -146,7 +146,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: '11'
java-version: '17'
- uses: gradle/wrapper-validation-action@v1
- uses: gradle/gradle-build-action@v2
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: '11'
java-version: '17'
- uses: gradle/wrapper-validation-action@v1
- uses: gradle/gradle-build-action@v2
env:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.bumble.appyx.components.experimental.cards" />
<manifest />
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.bumble.appyx.components.experimental.modal" />
<manifest />
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.bumble.appyx.components.experimental.promoter" />
<manifest />
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.bumble.appyx.components.experimental.puzzle15" />
<manifest />
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-components-experimental-puzzle15-web"
browser()
binaries.executable()
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumble.appyx.components.internal.testdrive.android">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<application android:theme="@android:style/Theme.Material.NoActionBar" />

Expand Down
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.bumble.appyx.components.internal.testdrive" />
<manifest />
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.bumble.appyx.components.backstack" />
<manifest />
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.bumble.appyx.components.spotlight.android">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

<application android:theme="@android:style/Theme.Material.NoActionBar" />

Expand Down
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.bumble.appyx.components.spotlight" />
<manifest />
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.bumble.appyx.interactions" />
<manifest />
1 change: 1 addition & 0 deletions demos/appyx-interactions/web/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-demos-interactions-web"
browser()
binaries.executable()
}
Expand Down
1 change: 1 addition & 0 deletions demos/appyx-navigation/web/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-demos-navigation-web"
browser()
binaries.executable()
}
Expand Down
2 changes: 1 addition & 1 deletion demos/common/src/androidMain/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.bumble.appyx.samples.common" />
<manifest />
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-demos-backstack-fader-web"
browser()
binaries.executable()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-demos-backstack-parallax-web"
browser()
binaries.executable()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-demos-backstack-slider-web"
browser()
binaries.executable()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-demos-backstack-stack3d-web"
browser()
binaries.executable()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-demos-experimental-datingcards-web"
browser()
binaries.executable()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-demos-experimental-puzzle15-web"
browser()
binaries.executable()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-components-spotlight-fader-web"
browser()
binaries.executable()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-components-spotlight-slider-web"
browser()
binaries.executable()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-components-spotlight-slider-rotation-web"
browser()
binaries.executable()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-components-spotlight-slider-scale-web"
browser()
binaries.executable()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-components-spotlight-stack3d-web"
browser()
binaries.executable()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-interactions-gestures-dragpredication-web"
browser()
binaries.executable()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-interactions-gestures-incompletedrag-web"
browser()
binaries.executable()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-interactions-observemp-web"
browser()
binaries.executable()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-interactions-sample1-web"
browser()
binaries.executable()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-interactions-sample2-web"
browser()
binaries.executable()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ plugins {

kotlin {
js(IR) {
moduleName = "appyx-interactions-sample3-web"
browser()
binaries.executable()
}
Expand Down
3 changes: 3 additions & 0 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
android.defaults.buildfeatures.buildconfig=true
android.nonFinalResIds=false
android.nonTransitiveRClass=false
android.useAndroidX=true
kotlin.code.style=official
kotlin.mpp.androidSourceSetLayoutVersion1.nowarn=true
Expand Down
6 changes: 3 additions & 3 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

[versions]
accompanist = "0.28.0"
agp = "7.4.1"
agp = "8.1.1"
androidCompileSdk = "33"
androidMinSdk = "21"
androidTargetSdk = "32"
Expand All @@ -16,7 +16,7 @@ coroutines = "1.6.4"
dependencyAnalysis = "1.13.1"
detekt = "1.21.0"
junit5 = "5.8.2"
jvmTarget = "11"
jvmTarget = "17"
kotlin = "1.8.10"
ksp = "1.8.0-1.0.8"
mvicore = "1.2.6"
Expand Down Expand Up @@ -87,7 +87,7 @@ junit-vintage = { module = "org.junit.vintage:junit-vintage-engine", version.ref

plugin-kotlin = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version.ref = "kotlin" }
plugin-detekt = { module = "io.gitlab.arturbosch.detekt:detekt-gradle-plugin", version.ref = "detekt" }
plugin-android = "com.android.tools.build:gradle:7.4.0"
plugin-android = { module = "com.android.tools.build:gradle", version.ref = "agp" }

detekt-compose = "com.twitter.compose.rules:detekt:0.0.26"
toolargetool = "com.gu.android:toolargetool:0.3.0"
Expand Down
Binary file modified gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
3 changes: 2 additions & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.1.1-bin.zip
networkTimeout=10000
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
25 changes: 18 additions & 7 deletions gradlew
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
# Darwin, MinGW, and NonStop.
#
# (3) This script is generated from the Groovy template
# https://github.com/gradle/gradle/blob/master/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
# https://github.com/gradle/gradle/blob/HEAD/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was changed as part of updating Gradle (this is not my code)

# within the Gradle project.
#
# You can find Gradle at https://github.com/gradle/gradle/.
Expand All @@ -80,13 +80,10 @@ do
esac
done

APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit

APP_NAME="Gradle"
# This is normally unused
# shellcheck disable=SC2034
APP_BASE_NAME=${0##*/}

# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit

# Use the maximum available, or set MAX_FD != -1 to use that value.
MAX_FD=maximum
Expand Down Expand Up @@ -143,12 +140,16 @@ fi
if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then
case $MAX_FD in #(
max*)
# In POSIX sh, ulimit -H is undefined. That's why the result is checked to see if it worked.
# shellcheck disable=SC3045
MAX_FD=$( ulimit -H -n ) ||
warn "Could not query maximum file descriptor limit"
esac
case $MAX_FD in #(
'' | soft) :;; #(
*)
# In POSIX sh, ulimit -n is undefined. That's why the result is checked to see if it worked.
# shellcheck disable=SC3045
ulimit -n "$MAX_FD" ||
warn "Could not set maximum file descriptor limit to $MAX_FD"
esac
Expand Down Expand Up @@ -193,6 +194,10 @@ if "$cygwin" || "$msys" ; then
done
fi


# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'

# Collect all arguments for the java command;
# * $DEFAULT_JVM_OPTS, $JAVA_OPTS, and $GRADLE_OPTS can contain fragments of
# shell script including quotes and variable substitutions, so put them in
Expand All @@ -205,6 +210,12 @@ set -- \
org.gradle.wrapper.GradleWrapperMain \
"$@"

# Stop when "xargs" is not available.
if ! command -v xargs >/dev/null 2>&1
then
die "xargs is not available"
fi

# Use "xargs" to parse quoted args.
#
# With -n1 it outputs one arg per line, with the quotes and backslashes removed.
Expand Down
Loading