Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flush output cache when onCreate is called in NodeConnector #591

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Flush output cache when onCreate is called in NodeConnector #591

merged 2 commits into from
Sep 13, 2023

Conversation

KovalevAndrey
Copy link
Collaborator

@KovalevAndrey KovalevAndrey commented Sep 13, 2023 •
edited
Loading

Description

The issue is described here #590

This is a quick fix for NodeConnector to flush output. Since onCreated is called when lifecycle is brought to onCreate state we can safely do this

Check list

  • I have updated CHANGELOG.md if required.
  • I have updated documentation if required.

@zsoltk zsoltk merged commit ebc6c90 into bumble-tech:2.x Sep 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsoltk zsoltk zsoltk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KovalevAndrey @zsoltk