Issue #558: Improve on accessibility for Spotlight #597
Conversation
vladcipariu91
added
appyx-interactions
appyx-components-spotlight
accessibility
enhancement
| customActions = | ||
| if (elementIndex == activeIndex) { | ||
| listOfNotNull( | ||
| CustomAccessibilityAction("Next") { |
There was a problem hiding this comment.
Not localised.
Also can you use non-custom actions that are used in androidx.compose.HorizontalPager?
https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/Pager.kt;l=726?q=androidx.compose.foundation.pager&sq=&ss=androidx – pageUp { } & pageDown { } on SampleChildren
https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/LazyLayoutSemanticState.kt;l=44 – CollectionInfo (you are already using it)
IDK how to make it focus the scrolled page (on your video it does not focus on it). probably somewhere in sources too. Please compare TalkBack behaviour to the default HorizontalPager.
Potentially SpotlightModel should be able to provide Modifier.semantics to both parent and each children.
vladcipariu91
changed the title
vladcipariu91
changed the title
vladcipariu91
changed the title
Description
Issue ticket
Issue 1:
I made a minor improvement to accessibility by adding semantic actions.
This UX is not ideal. For it to work properly I assume we need to get hold of a callback from TalkBack or semantics that tells us which item is currently selected and when the user performs another swipe gesture. Based on the swipe gestures direction we'll need to call the right function on the spotlight next() or previous().
Issue 2:
Fixed
I've attached a video:
ezgif.com-resize.mov
Check list
CHANGELOG.mdif required.