-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation sample app #625
Conversation
…gation-sample-app # Conflicts: # demos/appyx-navigation/common/src/commonMain/kotlin/com/bumble/appyx/navigation/node/checkout/CartContent.kt # demos/appyx-navigation/common/src/commonMain/kotlin/com/bumble/appyx/navigation/node/checkout/CartItemsNode.kt
This reverts commit 5676908.
…gation-sample-app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
detekt found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
...gation/common/src/commonMain/kotlin/com/bumble/appyx/navigation/composable/AppyxComponent.kt
Fixed
Show fixed
Hide fixed
utils/material3/src/commonMain/kotlin/com/bumble/appyx/utils/material3/AppyxNavItem.kt
Fixed
Show fixed
Hide fixed
utils/material3/src/commonMain/kotlin/com/bumble/appyx/utils/material3/AppyxNavItem.kt
Fixed
Show fixed
Hide fixed
@@ -25,7 +25,7 @@ android { | |||
signingConfig = signingConfigs.findByName("sampleConfig") | |||
} | |||
release { | |||
isMinifyEnabled = true | |||
isMinifyEnabled = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raise ticket to investigate?
val mode: StateFlow<SpotlightHeroModel.Mode> = model.output | ||
.mapState(scope) { it.currentTargetState.mode } | ||
|
||
private var _heroProgress: MutableStateFlow<StateFlow<Float>> = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol, we should probably flatten this in a separate ticket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHIP IT
Description
New sample app for Navigation
...
Check list
CHANGELOG.md
if required.