Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation sample app #625

Merged
merged 119 commits into from
Oct 27, 2023
Merged

Navigation sample app #625

merged 119 commits into from
Oct 27, 2023

Conversation

aashay-gaikwad
Copy link

@aashay-gaikwad aashay-gaikwad commented Oct 25, 2023

Description

New sample app for Navigation
...

Check list

  • I have updated CHANGELOG.md if required.
  • I have updated documentation if required.

mapm14 and others added 8 commits October 24, 2023 16:58
…gation-sample-app

# Conflicts:
#	demos/appyx-navigation/common/src/commonMain/kotlin/com/bumble/appyx/navigation/node/checkout/CartContent.kt
#	demos/appyx-navigation/common/src/commonMain/kotlin/com/bumble/appyx/navigation/node/checkout/CartItemsNode.kt
This reverts commit 5676908.
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detekt found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@@ -25,7 +25,7 @@ android {
signingConfig = signingConfigs.findByName("sampleConfig")
}
release {
isMinifyEnabled = true
isMinifyEnabled = false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raise ticket to investigate?

val mode: StateFlow<SpotlightHeroModel.Mode> = model.output
.mapState(scope) { it.currentTargetState.mode }

private var _heroProgress: MutableStateFlow<StateFlow<Float>> =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, we should probably flatten this in a separate ticket

Copy link
Collaborator

@mike-n-jordan mike-n-jordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIP IT

@mike-n-jordan mike-n-jordan merged commit 4b9404e into 2.x Oct 27, 2023
7 checks passed
@KovalevAndrey KovalevAndrey deleted the navigation-sample-app branch July 17, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants