Refactor AppyxComponent and application of draggable modifier #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...teractions/common/src/commonMain/kotlin/com/bumble/appyx/interactions/core/AppyxComponent.kt
Fixed
Show fixed
Hide fixed
…ppyxComponent's child composable.
KovalevAndrey
force-pushed
the
2.x-do-not-apply-if-no-gestures
branch
from
634ddfa to
e3aafe0
Compare
KovalevAndrey
changed the title
… into 2.x-do-not-apply-if-no-gestures
KovalevAndrey
commented
Dec 19, 2023
| } | ||
|
|
||
| @Composable | ||
| private fun <InteractionTarget : Any, ModelState : Any> ChildGestureSupportTransformBoundingBox( |
There was a problem hiding this comment.
At this point I'm not even sure if we need it
KovalevAndrey
force-pushed
the
2.x-do-not-apply-if-no-gestures
branch
from
0e27637 to
5d6e917
Compare
KovalevAndrey
force-pushed
the
2.x-do-not-apply-if-no-gestures
branch
from
5d6e917 to
241bef0
Compare
KovalevAndrey
commented
Jan 11, 2024
...n/src/commonMain/kotlin/com/bumble/appyx/interactions/core/ui/gesture/GestureSettleConfig.kt
Outdated
Show resolved
Hide resolved
KovalevAndrey
force-pushed
the
2.x-do-not-apply-if-no-gestures
branch
from
6c2b2c9 to
a2bfcfe
Compare
KovalevAndrey
force-pushed
the
2.x-do-not-apply-if-no-gestures
branch
2 times, most recently
from
11810d0 to
bc586ac
Compare
…ply-if-no-gestures
KovalevAndrey
force-pushed
the
2.x-do-not-apply-if-no-gestures
branch
from
bc586ac to
3f9a701
Compare
zsoltk
reviewed
Jan 19, 2024
| @@ -50,6 +50,11 @@ import com.bumble.appyx.interactions.core.ui.property.motionPropertyRenderValue | |||
|
|
|||
| private val defaultExtraTouch = 48f.dp | |||
|
|
|||
| enum class GesturesRelation { | |||
There was a problem hiding this comment.
- I'd extract this to a standalone file in the gestures package
- I'd rename to
GesturesReferencePoint - I'd provide some comments on what they do
There was a problem hiding this comment.
Also for consistency, probably use singular rather than plural, the same as everywhere else
zsoltk
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
appyx-interactionnow takes lambda for drawing children composable. Transition container is applied inside so we clients don't need to apply it themselves. Lambda has only one parameterElementinstead ofElementUiModelappyx-navigationtakes lamda for decorating children composable UI. The UI itself is taken from Nodes. Lambda has only one parameterElementinstead ofElementUiModelso we don't expose more than we shouldisGestureBoundingBoxTransformedwhich takes into consideration rotation of the element when applying draggable modifier.Check list
CHANGELOG.mdif required.