Fix iOS lifecycle #660
Closed
Fix iOS lifecycle #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...navigation/common/src/iosMain/kotlin/com/bumble/appyx/navigation/platform/LifecycleHelper.kt
Fixed
Show fixed
Hide fixed
zsoltk
reviewed
Jan 22, 2024
# Conflicts: # CHANGELOG.md
zsoltk
reviewed
Jan 25, 2024
| @@ -18,6 +18,7 @@ Please refer to [2.0.0-alpha10 – Migration guide](2.0.0-alpha10.md) | |||
| - [#654](https://github.com/bumble-tech/appyx/pull/654) - Renamings | |||
| - [#657](https://github.com/bumble-tech/appyx/pull/657) - Rename ParentNode & Node to Node and LeafNode | |||
| - [#644](https://github.com/bumble-tech/appyx/pull/644) – Refactor AppyxComponent and application of draggable modifier | |||
| - [#660](https://github.com/bumble-tech/appyx/pull/660) - Make IosNodeHost to receive a Lifecycle class to fix iOS lifecycle problems | |||
There was a problem hiding this comment.
Let's move this to pending changes, alpha10 is already released
| @@ -17,6 +17,7 @@ Please refer to [2.0.0-alpha10 – Migration guide](2.0.0-alpha10.md) | |||
| - [#652](https://github.com/bumble-tech/appyx/pull/652) - KSP processor renamed from `mutable-ui-processor` to `appyx-processor` | |||
| - [#654](https://github.com/bumble-tech/appyx/pull/654) - Renamings | |||
| - [#657](https://github.com/bumble-tech/appyx/pull/657) - Rename ParentNode & Node to Node and LeafNode | |||
| - [#660](https://github.com/bumble-tech/appyx/pull/660) - Make IosNodeHost to receive a Lifecycle class to fix iOS lifecycle problems | |||
There was a problem hiding this comment.
Better to surround code related names with `
| } | ||
| .onOpenURL { incomingURL in | ||
| Main_iosKt.handleDeepLinks(url: incomingURL) | ||
| } | ||
| .onChange(of: scenePhase) { newPhase in |
There was a problem hiding this comment.
Nitpick: fix indentation
Comment on lines
+21
to
29
| .onChange(of: scenePhase) { newPhase in | ||
| switch newPhase { | ||
| case .background: appDelegate.lifecycleHolder.lifecycleHelper.created() | ||
| case .inactive: appDelegate.lifecycleHolder.lifecycleHelper.created() | ||
| case .active: appDelegate.lifecycleHolder.lifecycleHelper.resumed() | ||
| @unknown default: break | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Nitpick: fix indentation
|
Fixed in #670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix iOS Lifecycle
Currently, the app's iOS lifecycle wasn't working as expected, when the app was going to the background the Appyx Nodes were not updating their lifecycle states as expected.
This PR solves the issue by making the iOS app to pass the app Lifecycle to the
iOSNodeHost.VEED.CREATE.Edit.mp4
Check list
CHANGELOG.mdif required.