-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Gradle & Kotlin #662
Upgrade Gradle & Kotlin #662
Conversation
…x into upgrade-gradle-kotlin
…st gradle version
compose.experimental { | ||
uikit.application { | ||
projectName = "Appyx" | ||
bundleIdPrefix = "com.bumble.appyx" | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer needed as uikit
has been removed from compose.experimental
, and this same configuration can now be done in Config.xconfig
files.
compose.experimental { | ||
uikit.application { | ||
projectName = "Appyx" | ||
bundleIdPrefix = "com.bumble.appyx" | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer needed as uikit has been removed from compose.experimental, and this same configuration can now be done in Config.xconfig files.
compose.experimental { | ||
uikit.application { | ||
projectName = "Appyx" | ||
bundleIdPrefix = "com.bumble.appyx" | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer needed as uikit has been removed from compose.experimental, and this same configuration can now be done in Config.xconfig files.
@@ -4,6 +4,7 @@ android.nonTransitiveRClass=false | |||
android.useAndroidX=true | |||
kotlin.code.style=official | |||
kotlin.mpp.androidSourceSetLayoutVersion1.nowarn=true | |||
kotlin.mpp.applyDefaultHierarchyTemplate=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This option has been added to avoid warnings related to the Default Kotlin Hierarchy Template
not being applied in many modules. It is advisable to address the related configuration in a separate ticket.
kotlin = "1.9.21" | ||
ksp = "1.9.21-1.0.16" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kotlin 1.9.20
is skipped due to an issue with KSP that makes it impossible to compile the library with this version.
Description
The main goal of this ticket is to upgrade Gradle and Kotlin to newer versions. The following are the newly applied versions:
8.5
1.9.21
1.9.21-1.0.16
8.2.1
1.5.7
1.5.11
1.29.0
Check list
CHANGELOG.md
if required.