Appyx 2.x - Rename integration point #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuel-martos
changed the title
zsoltk
reviewed
Jan 26, 2024
Comment on lines
-83
to
-103
| ### MainActivity | ||
|
|
||
| ```diff | ||
| -import com.bumble.appyx.core.integration.NodeHost | ||
| -import com.bumble.appyx.core.integrationpoint.NodeActivity | ||
|
|
||
| +import com.bumble.appyx.navigation.integration.NodeHost | ||
| +import com.bumble.appyx.navigation.integration.NodeActivity | ||
|
|
||
| class MainActivity : NodeActivity() { | ||
| super.onCreate(savedInstanceState) | ||
| setContent { | ||
| HelloAppyxTheme { | ||
| - NodeHost(integrationPoint = appyxIntegrationPoint) { | ||
| + NodeHost(integrationPoint = appyxV2IntegrationPoint) { | ||
| RootNode(it) | ||
| } | ||
| } | ||
| } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Maybe it's better if instead of removing this block we update it. After merging #668, let's make a new release in the scope of 1.x
Then we could update this above block to say something like:
"If you migrate all of your codebase from 1.x to 2.x in a single go, you should skip this step. However, if you intend to keep them in parallel for a gradual migration, you must do the following:
- Update your 1.x version to [release containing Appyx 1.x - Rename integration point #668]
- Rename
appyxIntegrationPointusage in 1.x code toappyxV1IntegrationPoint:(include the above code but for 1.x)
There was a problem hiding this comment.
Let's do this as a standalone PR for documentation when we have the 1.x version out. Merging this ticket now to close API.
zsoltk
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CHANGELOG.mdif required.