Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppyxComponent state not restored after configuration changes #694

Merged
merged 8 commits into from
Apr 12, 2024
Merged

AppyxComponent state not restored after configuration changes #694

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cb94a57
Merge branch '2.x' of github.com:manuel-martos/appyx into 2.x
mmartosdev Apr 12, 2024
884b69a
Node initialisation wasn't adding necesary plugins
mmartosdev Apr 12, 2024
482f932
Update CHANGELOG + add test
mmartosdev Apr 12, 2024
d4b87a7
Update CHANGELOG
mmartosdev Apr 12, 2024
06e6d4e
Move test to UI
mmartosdev Apr 12, 2024
b43149e
Add extra test to make sure saveInstanceState has been invoked
mmartosdev Apr 12, 2024
c9cb504
Rollback coroutines version
mmartosdev Apr 12, 2024
b54d891
Fix coroutine version
mmartosdev Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appyx-navigation/common/src/commonMain/kotlin/com/bumble/appyx/navigation/node/Node.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ abstract class Node<NavTarget : Any>(
val id: String
get() = nodeContext.identifier

val plugins: List<Plugin> = plugins + listOfNotNull(this as? Plugin)
val plugins: List<Plugin> = plugins + appyxComponent + childAware + listOfNotNull(this as? Plugin)

val ancestryInfo: AncestryInfo =
nodeContext.ancestryInfo
Expand Down