Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New page linker #58

Merged
merged 4 commits into from
Oct 31, 2023
Merged

New page linker #58

merged 4 commits into from
Oct 31, 2023

Conversation

shcherbanich
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Using empty links like <a>ClassName</a> or <a x-title='some title'>ClassName</a> can be too confusing, since it is probably not entirely clear that the content inside the tag will be the link. To fix this, I decided to implement empty links in a different format, namely: [a]SomeClass[/a] or [a x-title='some title']SomeClass[/a]. Since this is not a standard tag, the question of the illogical nature of filling the link disappears.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added/updated tests.

@shcherbanich shcherbanich requested a review from seanmcn October 28, 2023 08:10
@seanmcn seanmcn marked this pull request as ready for review October 31, 2023 11:11
Copy link
Collaborator

@seanmcn seanmcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I think this will also help with AI content generation.

@shcherbanich shcherbanich merged commit 919abfd into 1.x.x Oct 31, 2023
1 check passed
@shcherbanich shcherbanich deleted the new_page_linker branch October 31, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants