Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization of the caching and error handling mechanism #63

Merged
merged 10 commits into from
Nov 2, 2023

Conversation

shcherbanich
Copy link
Contributor

@shcherbanich shcherbanich commented Nov 2, 2023

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

After implementing the new error reporting system, we disabled caching for pages with errors. But the entities still had a cache. I fixed this and during the fix I found several problems that also needed to be fixed, namely incorrect processing of entities that are included from composer and error handling

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added/updated tests.

@shcherbanich shcherbanich marked this pull request as ready for review November 2, 2023 13:40
@shcherbanich shcherbanich requested a review from seanmcn November 2, 2023 13:41
@shcherbanich shcherbanich merged commit a0f0d42 into 1.x.x Nov 2, 2023
1 check passed
@shcherbanich shcherbanich deleted the changing_cache_operation_when_errors_occur branch November 2, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants