Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: CMS fields issue #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FIX: CMS fields issue #16

wants to merge 1 commit into from

Conversation

a2nt
Copy link
Contributor

@a2nt a2nt commented Aug 28, 2017

This function won't work in case CMS was modified or in case extension extends an object:
$fields->addFieldsToTab('Root.Main', array(
$gridField
), 'Metadata');

This function won't work in case CMS was modified or in case extension extends an object:
$fields->addFieldsToTab('Root.Main', array(
            $gridField
        ), 'Metadata');
@bummzack
Copy link
Owner

The extension was specifically designed to be added to Pages, not DataObjects (I don't think the publish page & blocks action is going with DataObjects…).

If you modify the fields, make sure your code modifies the fields before the extension applies its logic. You'll only run into problems when you remove the Metadata field before the extension is applied.

@a2nt
Copy link
Contributor Author

a2nt commented Aug 28, 2017

why won't work I think will work ok with versioned DataObjects?

@bummzack
Copy link
Owner

Have you tried it? The PublishAllExtension that is being used for the "Publish Page & Blocks" action doesn't consider versioned DataObjects at the moment.

You can easily add page-blocks to your dataobject, but you should do so manually or with another extension, not by using the PageBlocks extension. Just use the GridFieldConfig_BlockEditor config and create a GridField with it…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants