Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for encrypted SSH keys + MySQL socket #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

benface
Copy link

@benface benface commented Dec 9, 2019

First of all, thank you for open sourcing this. I didn't realize I needed such a tool until I tried it.

This PR adds two features that I personally needed and that can hopefully benefit others:

Feedback welcome! Thank you :)

@ben-rogerson
Copy link
Member

Hey Ben, thanks so much for the new features!
From the looks of things you added the passphrase to the SSH session task and I'm thinking it might also be good to add it to some of the other tasks.
I'm away on holidays until the start of January so I'll plan on rolling it into a new release then.

@benface
Copy link
Author

benface commented Dec 15, 2019

Thanks @ben-rogerson! I appreciate you taking the time to look at it.

From the looks of things you added the passphrase to the SSH session task and I'm thinking it might also be good to add it to some of the other tasks.

I think I added it to every task by modifying the sshConnect function? I could be wrong though.

@ben-rogerson
Copy link
Member

That sounds about right, ill have to take a better look. Ill be in touch 👍

@ben-rogerson
Copy link
Member

So turns out this is quite a task as there are a few different types of connection functions used throughout the other tasks. Not sure which route I'll take on this yet, but at the very least I'll be able to put through the DB_SOCKET feature.

@benface
Copy link
Author

benface commented Feb 11, 2020

@ben-rogerson Can you give me an example of a function that doesn’t support encrypted keys in this PR? I was pretty sure I tested everything, but maybe I forgot some?

@ben-rogerson
Copy link
Member

Take a look at the work on the 1.6.0 branch: https://github.com/burgerbuds/swiff/commits/release/v1.6.0
It was a while back now, I can't remember which functions needed updates - sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants