Merge pull request #188 from skie/2.0

fix url generation in cake if hash is empty
burzum · Apr 11, 2019 · e0cc17e · e0cc17e
2 parents e566dd7 + 709582f
commit e0cc17e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/View/Helper/ImageHelper.php b/src/View/Helper/ImageHelper.php
@@ -92,7 +92,10 @@ protected function _getHash($version, $image) {
 	public function imageUrl($image, $version = null, $options = []) {
 		$fileInfo = pathinfo($image['path']);
 		$hash = $this->_getHash($version, $image);
-		$version = $fileInfo['dirname'] . DS . $fileInfo['filename'] . '.' . $hash;
+        $version = $fileInfo['dirname'] . DS . $fileInfo['filename'];
+        if ($hash !== null) {
+            $version .= '.' . $hash;
+        }
 
 		if (!empty($fileInfo['extension'])) {
 			$version .= '.' . $fileInfo['extension'];

diff --git a/tests/TestCase/View/Helper/ImageHelperTest.php b/tests/TestCase/View/Helper/ImageHelperTest.php
@@ -81,6 +81,9 @@ public function testImageUrl() {
 
 		$result = $this->Image->imageUrl($image, 't150', ['pathPrefix' => '/src/']);
 		$this->assertEquals('/src/test/path/testimage.c3f33c2a.jpg', $result);
+
+		$result = $this->Image->imageUrl($image, null, ['pathPrefix' => '/src/']);
+		$this->assertEquals('/src/test/path/testimage.jpg', $result);
 	}
 
 	/**