Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility improvements on newly added features #2920

Merged
merged 8 commits into from
May 10, 2024
Merged

Conversation

TheDancingClown
Copy link
Contributor

@TheDancingClown TheDancingClown commented May 10, 2024

📝 A short description of the changes

  • Deactivate assessors feature - the radio button label is clickable however it is not obvious to the user so hover styles are added to increase the clickable target.
  • Adds more descriptions to error messages on matrix and by_year questions
  • Adds aria attributes to file uploads

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

  • None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

@TheDancingClown TheDancingClown changed the title A11y audit Accessibility improvements on newly added features May 10, 2024
@TheDancingClown TheDancingClown marked this pull request as ready for review May 10, 2024 13:26
@TheDancingClown TheDancingClown merged commit 42ea9bc into main May 10, 2024
11 checks passed
@TheDancingClown TheDancingClown deleted the a11y-audit branch May 10, 2024 13:35
@TheDancingClown TheDancingClown mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants