Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate list of file uploads in admin panel #2922

Merged
merged 1 commit into from
May 10, 2024
Merged

Remove duplicate list of file uploads in admin panel #2922

merged 1 commit into from
May 10, 2024

Conversation

DaniBitZesty
Copy link
Contributor

📝 A short description of the changes

  • Commenting out this block because it in combination with #commercial-figures-section section, file links are duplicated. No present need for this but keeping it for future reference

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

@DaniBitZesty DaniBitZesty marked this pull request as draft May 10, 2024 12:28
@DaniBitZesty DaniBitZesty force-pushed the remove-duplicate-list-of-uploads branch from 8471314 to 563e7a3 Compare May 10, 2024 12:29
@DaniBitZesty DaniBitZesty marked this pull request as ready for review May 10, 2024 12:29
@DaniBitZesty DaniBitZesty force-pushed the remove-duplicate-list-of-uploads branch from 563e7a3 to 16e21d9 Compare May 10, 2024 12:30
@DaniBitZesty DaniBitZesty changed the title Remove duplicate list of uploads Remove duplicate list of file uploads in admin panel May 10, 2024
dreamfall
dreamfall reviewed May 10, 2024
View reviewed changes
app/views/admin/form_answers/docs/_post_shortlisting_docs.html.slim
/ - resource.vat_returns_files.each do |vat_returns_file|
/ = render "admin/form_answers/docs/scanned_file_link", file: vat_returns_file, url_namespace: url_namespace
/ - if cff = resource.shortlisted_documents_wrapper.commercial_figures_file
/ = render "admin/form_answers/docs/scanned_file_link", file: cff, url_namespace: url_namespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have no intention of using it, just delete the code.

@DaniBitZesty
Commenting out old list of 'post_shortlisting_docs', we currently dis…
55bd9ec 
…play these differently in commercial-figures-section section
@DaniBitZesty DaniBitZesty force-pushed the remove-duplicate-list-of-uploads branch from 37d799f to 55bd9ec Compare May 10, 2024 15:46
@DaniBitZesty DaniBitZesty merged commit d50c141 into main May 10, 2024
11 checks passed
@DaniBitZesty DaniBitZesty deleted the remove-duplicate-list-of-uploads branch May 10, 2024 16:10
@TheDancingClown TheDancingClown mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamfall dreamfall dreamfall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniBitZesty @dreamfall