Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes conditional for latest year end question #2950

Closed
wants to merge 1 commit into from
Closed

Conversation

Lubosky
Copy link
Contributor

@Lubosky Lubosky commented May 23, 2024

📝 A short description of the changes

  • Removes conditional to always show the question to change the year end for Innovation and International Trade

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

  • None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

Screenshot 2024-05-23 at 10 43 18

@Lubosky
Copy link
Contributor Author

Lubosky commented May 23, 2024

Closing this as the previously reverted changes were actually OK.

@Lubosky Lubosky closed this May 23, 2024
@matthewford matthewford deleted the fy-end-merge branch January 23, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants