Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility fixes on recent features added #2955

Merged
merged 4 commits into from
May 24, 2024
Merged

Conversation

TheDancingClown
Copy link
Contributor

📝 A short description of the changes

  • Where the visuallyhidden class was used for the text 'No documents attached', this was read by screen readers even when documents had been attached. These have been replaced with hide class which has display: none style.
  • Improved messages to be more specific to the sidebar section
  • Added a column header to the Overall Turnover Growth table. Also changed table headers to match the table headings.
  • Changed word count text to a darker grey to fix contrast issue against grey background

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

  • None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

Screenshot 2024-05-24 at 11 24 42

@DaniBitZesty DaniBitZesty merged commit 4f044cb into main May 24, 2024
11 checks passed
@DaniBitZesty DaniBitZesty deleted the accessibility-hide branch May 24, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants