Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial support PROJ ellipsoid definitions #64

Merged

Conversation

Rennzie
Copy link
Contributor

@Rennzie Rennzie commented Oct 13, 2023

PROJ has rich support for defining an ellipsoid in a proj string. RG only supports the builtins or definitions via ellps=a,rf syntax. This PR adds support for reworking a and rf parameters in a proj string to ellps=a,rf. This support is added to parse_proj as it felt like the cleanest approach.

I opted for ignoring ALL other cases as they seemed more difficult to fix. I've added some documentation to parse_proj to indicate to users what they can expect.

I've also tacked on a small tidyup to proj strings whereby a scaling k parameter gets converted to k_0.

closes #61

Copy link
Owner

@busstoptaktik busstoptaktik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nitpicking comments and two general hoorays :-)

src/token/mod.rs Show resolved Hide resolved
src/token/mod.rs Outdated Show resolved Hide resolved
src/token/mod.rs Outdated Show resolved Hide resolved
src/token/mod.rs Show resolved Hide resolved
@busstoptaktik busstoptaktik merged commit 7fc70ca into busstoptaktik:main Oct 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should RG accept ellipse params as well as an ellps=<name>?
2 participants