-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NTv2 multi subgrid support #74
Add NTv2 multi subgrid support #74
Conversation
@Rennzie: In #75, I corrected the interpolation bug, and added a tiny NTv2 file (built using the I spent quite some time trying to dig up an actual license for the Saskatchewan file, and while I suspect it is covered by the Government of Saskatchewan Standard Unrestricted Use Data Licence Version 2.0), I cannot know for sure, and I would really prefer not to pollute the licensing space of RG with any non-interoperable special-purpose bessermachen licenses. It's CC-BY, CC0 and really not anything else. So I think my hand-crafted solution is the better alternative, and it was easier and cheaper than hiring a lawyer to untangle things 😊 To be absolutely sure the Saskatchewan file does not accidentally get merged through multiple-commit-history, I would prefer to see this PR restarted as a new branch, branching off from main, and not including the Saskatchewan file at any moment in its commit history. I.e. not just rebasing (because then commit history and hence historically committed material will creep into the repo) but hand held direct diffing of the relevant files from branch to branch. Or, since you may very well speak That said: There is a minor conflict in |
2681734
to
8d4745e
Compare
@busstoptaktik thats absolutely no problem. I'll remove all references, commits etc to that .gsb file. I think I can do it in this branch as it was only a single commit that references it. I'll update the description too. Thanks for adding a multi level .gsb. I'll be able to write better tests now too. And thanks also for fixing the precision of the grid interpolation. That will be extremely useful. I'll be testing a number of different .gsb files for work soon so this is timely 🎉 |
8d4745e
to
8f8b8b5
Compare
3cd469c
to
068dca5
Compare
@busstoptaktik this is ready for another look. With your hand rolled subgrid .gsb I've managed to make the |
Adds support for multiple NTv2 subgrids. The implementation is adapted from the FGRID subroutine described in the archived spec (pg 42).
I've done my best to be fully compliant to the FGRID rules of NTv2. There may be some edge cases missing though.