This repository has been archived by the owner on Oct 21, 2024. It is now read-only.
Run post_github_summary_message coroutine via RQ #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
==========================================
- Coverage 89.51% 89.38% -0.14%
==========================================
Files 71 71
Lines 2509 2506 -3
==========================================
- Hits 2246 2240 -6
- Misses 263 266 +3
Continue to review full report at Codecov.
|
alysivji
commented
Aug 28, 2021
| @@ -6,19 +6,30 @@ def add(x, y): | |||
| return x + y | |||
|
|
|||
|
|
|||
| @rq.job | |||
| @@ -54,26 +52,11 @@ def _create_async_client(self): | |||
| """Generate client used for making asynchronous requests""" | |||
| return httpx.AsyncClient(headers=self.headers, params=self.params) | |||
|
|
|||
| def get_activity_for_users( | |||
| async def get_activity_for_users( | |||
There was a problem hiding this comment.
this read a lot better now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do
post_github_summary_messagevia RQWhy are we doing this
Don't have to manually queue up coroutines via asyncio. Results in a cleaner API
How should this be tested
Added pytest-asyncio to make it easier to test coroutines
Migrations
n/a
Dependencies
n/a
Callouts
n/a