Rename HttpServer to ServerPrefix, and do not listen on it directly #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename HttpServer to ServerPrefix, which is closer to the terminology used in https://datatracker.ietf.org/doc/html/rfc6962#section-4 and in https://github.com/C2SP/C2SP/blob/main/static-ct-api.md#checkpoints to describe the prefix of the CA server. In the future, this can be used as an identifier for the server (e.g., as a checkpoint origin line). Also do not listen on ServerPrefix directly with the 'mtc ca serve' subcommand, since it may not be in 'host:port' format. The `listen-addr` flag provides the listening address for the server, and we assume that it's behind a reverse proxy that ensures that requests to ServerPrefix are routed correctly. Closes #22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename HttpServer to ServerPrefix, which is closer to the terminology
used in https://datatracker.ietf.org/doc/html/rfc6962#section-4 and in
https://github.com/C2SP/C2SP/blob/main/static-ct-api.md#checkpoints to
describe the prefix of the CA server. In the future, this can be used as
an identifier for the server (e.g., as a checkpoint origin line).
Also do not listen on ServerPrefix directly with the 'mtc ca serve'
subcommand, since it may not be in 'host:port' format. The
listen-addrflag provides the listening address for the server, and we assume that
it's behind a reverse proxy that ensures that requests to ServerPrefix
are routed correctly.
Unrelated:
Closes #22