Fixes to appease go static checker #1589
Conversation
| @@ -51,7 +51,6 @@ func registerInterfaceProvider(eh EventInterfaceProvider) { | |||
| // fmt.Errorf("event %s already registered", eh.Type()) | |||
| } | |||
| registeredInterfaceProviders[eh.Type()] = eh | |||
| return | |||
There was a problem hiding this comment.
Unnecessary return removed
| @@ -52,6 +52,4 @@ func ExampleApplication() { | |||
| // Delete the application we created. | |||
| err = dg.ApplicationDelete(ap.ID) | |||
| log.Printf("Delete: err: %+v\n", err) | |||
|
|
|||
| return | |||
There was a problem hiding this comment.
Unnecessary return removed
| @@ -1061,7 +1062,7 @@ func (s *State) OnInterface(se *Session, i interface{}) (err error) { | |||
| oldCopy := *old | |||
| t.BeforeUpdate = &oldCopy | |||
| } | |||
| err = s.ChannelAdd(t.Channel) | |||
There was a problem hiding this comment.
This error value is never used
| @@ -1078,7 +1079,7 @@ func (s *State) OnInterface(se *Session, i interface{}) (err error) { | |||
| oldCopy := *old | |||
| t.BeforeUpdate = &oldCopy | |||
| } | |||
| err = s.ChannelAdd(t.Channel) | |||
There was a problem hiding this comment.
This error value is never used
There was a problem hiding this comment.
I think it's better to fix the shadowing rather than its consequences.
| @@ -501,8 +501,6 @@ func (v *VoiceConnection) onEvent(message []byte) { | |||
| default: | |||
| v.log(LogDebug, "unknown voice operation, %d, %s", e.Operation, string(e.RawData)) | |||
| } | |||
|
|
|||
| return | |||
There was a problem hiding this comment.
Unnecessary return removed
| @@ -787,7 +785,8 @@ func (v *VoiceConnection) opusSender(udpConn *net.UDPConn, close <-chan struct{} | |||
| sequence++ | |||
| } | |||
|
|
|||
| if (timestamp + uint32(size)) >= 0xFFFFFFFF { | |||
There was a problem hiding this comment.
The value given is greater than the max value of Uint32 which is impossible. Instead, we should check for integer ovrflow.
|
@FedorLap2006 @bwmarrin bump |
|
@FedorLap2006 Can you merge please? I don't have merge perms |
| @@ -1078,7 +1079,7 @@ func (s *State) OnInterface(se *Session, i interface{}) (err error) { | |||
| oldCopy := *old | |||
| t.BeforeUpdate = &oldCopy | |||
| } | |||
| err = s.ChannelAdd(t.Channel) | |||
There was a problem hiding this comment.
I think it's better to fix the shadowing rather than its consequences.
Resolve some complaints from the static go checker