-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added InsertBulkQuery #24
Open
byjg
wants to merge
4
commits into
master
Choose a base branch
from
5.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,109 @@ | ||
<?php | ||
|
||
namespace ByJG\MicroOrm; | ||
|
||
use ByJG\AnyDataset\Db\DbFunctionsInterface; | ||
use ByJG\MicroOrm\Exception\OrmInvalidFieldsException; | ||
use ByJG\MicroOrm\Interface\QueryBuilderInterface; | ||
use InvalidArgumentException; | ||
|
||
class InsertBulkQuery extends Updatable | ||
{ | ||
protected array $fields = []; | ||
|
||
protected ?QueryBuilderInterface $query = null; | ||
|
||
protected ?SqlObject $sqlObject = null; | ||
|
||
public function __construct(string $table, array $fieldNames) | ||
{ | ||
$this->table($table); | ||
|
||
foreach ($fieldNames as $fieldname) { | ||
$this->fields[$fieldname] = []; | ||
} | ||
} | ||
|
||
|
||
public static function getInstance(string $table, array $fieldNames): static | ||
{ | ||
return new InsertBulkQuery($table, $fieldNames); | ||
} | ||
|
||
/** | ||
* @throws OrmInvalidFieldsException | ||
*/ | ||
public function values(array $values, bool $allowNonMatchFields = true): static | ||
{ | ||
if (array_diff(array_keys($this->fields), array_keys($values))) { | ||
throw new OrmInvalidFieldsException('The provided values do not match the expected fields'); | ||
} | ||
|
||
if (!$allowNonMatchFields && array_diff(array_keys($values), array_keys($this->fields))) { | ||
throw new OrmInvalidFieldsException('The provided values contain more fields than expected'); | ||
} | ||
|
||
foreach (array_keys($this->fields) as $field) { | ||
$this->fields[$field][] = $values[$field]; | ||
} | ||
|
||
return $this; | ||
} | ||
|
||
/** | ||
* @param DbFunctionsInterface|null $dbHelper | ||
* @return SqlObject | ||
* @throws OrmInvalidFieldsException | ||
*/ | ||
public function build(DbFunctionsInterface $dbHelper = null): SqlObject | ||
{ | ||
if (empty($this->fields)) { | ||
throw new OrmInvalidFieldsException('You must specify the fields for insert'); | ||
} | ||
|
||
$tableStr = $this->table; | ||
if (!is_null($dbHelper)) { | ||
$tableStr = $dbHelper->delimiterTable($tableStr); | ||
} | ||
|
||
// Extract column names | ||
$columns = array_keys($this->fields); | ||
|
||
// Get the number of rows | ||
$rowCount = count(current($this->fields)); | ||
|
||
// Initialize placeholders and parameters | ||
$placeholders = []; | ||
$params = []; | ||
|
||
// Build placeholders and populate $params | ||
for ($i = 0; $i < $rowCount; $i++) { | ||
$rowPlaceholders = []; | ||
foreach ($columns as $j => $col) { | ||
$paramKey = "p{$i}_$j"; // Generate the parameter key | ||
$rowPlaceholders[] = ":$paramKey"; // Add to row placeholders | ||
$params[$paramKey] = $this->fields[$col][$i]; // Map parameter key to value | ||
} | ||
$placeholders[] = '(' . implode(', ', $rowPlaceholders) . ')'; // Add row placeholders to query | ||
} | ||
|
||
if (!is_null($dbHelper)) { | ||
$columns = $dbHelper->delimiterField($columns); | ||
} | ||
|
||
// Construct the final SQL query | ||
$sql = sprintf( | ||
"INSERT INTO %s (%s) VALUES %s", | ||
$tableStr, | ||
implode(', ', $columns), | ||
implode(', ', $placeholders) | ||
); | ||
|
||
return new SqlObject(ORMHelper::processLiteral($sql), $params); | ||
} | ||
|
||
public function convert(?DbFunctionsInterface $dbDriver = null): QueryBuilderInterface | ||
{ | ||
throw new InvalidArgumentException('It is not possible to convert an InsertBulkQuery to a Query'); | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incomplete error context for extra fields
Tell me more
What is the issue?
The error message does not specify which extra fields were provided.
Why this matters
Without knowing which fields are extra, developers will have difficulty identifying the source of the validation failure.
💡 Does this comment miss the mark? Tell us why and Korbit will adapt to your team’s feedback.
💬 Chat with Korbit by mentioning @korbit-ai.