Fix timer when fortifying buildings at max level #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A OG developer oversight that might have been in the game till it's very end. It would seem that they did not account for anything related to fortification when it came to the resource animation. When a building would get fortified it would grab the next level info for upgrades and the animation. This fails when buildings would be max level since there is no data for the next level.
In an effort to reduce complexity of a simple cosmetic operation this fix has been implemented so that when the NaN (not a number)/null upgrade data get's detected it fills it with the proper fortify data.
Functionally less work to be done and less areas of future fault, cosmetically fortify resource animation will contain the right amounts and types of resources only when the buildings are at max level (If people care or we are so far ahead where we need to worry about fixing the cosmetic parts of the game we'll change it then).