Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ioctl helper for integer arg #1172

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

notgull
Copy link
Contributor

@notgull notgull commented Sep 22, 2024

Fixing low-hanging-fruit issue #1051.

@sunfishcode
Copy link
Member

Would it be feasible to add a test that uses this new helper?

@notgull notgull force-pushed the int-setter branch 4 times, most recently from 9455c91 to a0b81d9 Compare September 27, 2024 17:27
@notgull
Copy link
Contributor Author

notgull commented Sep 27, 2024

Added!

Fixing low-hanging-fruit issue bytecodealliance#1051.

Signed-off-by: John Nunley <[email protected]>
@notgull
Copy link
Contributor Author

notgull commented Sep 30, 2024

@sunfishcode poke

@sunfishcode sunfishcode merged commit c7a21b8 into bytecodealliance:main Oct 5, 2024
43 checks passed
@notgull notgull deleted the int-setter branch October 10, 2024 22:54
sunfishcode pushed a commit that referenced this pull request Oct 17, 2024
Fixing low-hanging-fruit issue #1051.

Signed-off-by: John Nunley <[email protected]>
sunfishcode pushed a commit that referenced this pull request Oct 17, 2024
Fixing low-hanging-fruit issue #1051.

Signed-off-by: John Nunley <[email protected]>
sunfishcode pushed a commit that referenced this pull request Oct 20, 2024
Fixing low-hanging-fruit issue #1051.

Signed-off-by: John Nunley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants