-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a pure Wasm image classification benchmark #270
Add a pure Wasm image classification benchmark #270
Conversation
Add a benchmark which performs image classification in pure Wasm using tract and ONNX. This can be useful to track the performance of float heavy computations.
I think the rebuild failure is due to libsodium now requiring zig 0.12, but the Dockerfile uses zig 0.10.1. |
Rebuild failure should be fixed in #271 |
echo "Downloading model to $MODEL_FILE" | ||
|
||
if which wget >/dev/null ; then | ||
wget $MODEL_URL -O $MODEL_FILE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An assets directory needs to be created first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, thanks I'll fix that.
@adambratschikaye I was not familiar with tract but was introduced by your issue here: bytecodealliance/wasmtime#8313, so thanks for submitting. I think getting this in now is great but ultimately maybe this directory could be refactored to include multiple inferencing scenarios. |
I'm not exactly sure what's up with the current failure. It looks like the mac tests are failing with:
so maybe something is up with the cached wasmtime engine for mac? |
@adambratschikaye Looks like you were right. Not sure the corruption, but it was using an incorrect cached version of the wasmtime-engine. I removed the cached image for macos and reran so that it had to build again, and now all tests pass. |
Add a benchmark which performs image classification in pure Wasm using tract and ONNX. This can be useful to track the performance of float heavy computations.