Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search for a default expected file and include for libsodium #278

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Add search for a default expected file and include for libsodium #278

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08e4e25
Add search for a default expected file and include for libsodium
jlb6740 Aug 16, 2024
a4c14df
Add expected files for libsodium with non-default output.
jlb6740 Aug 24, 2024
0727eaa
Update crates/cli/src/benchmark.rs
jlb6740 Aug 27, 2024
22fc2dd
Update crates/cli/src/benchmark.rs
jlb6740 Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added benchmarks/libsodium/default.stderr.expected
View file
Open in desktop
Empty file.
1 change: 1 addition & 0 deletions benchmarks/libsodium/default.stdout.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
0
10 changes: 8 additions & 2 deletions crates/cli/src/benchmark.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,14 @@ impl BenchmarkCommand {
.with_context(|| "expected the benchmark file to have an extension")?
.to_str()
.with_context(|| "expected the benchmark file to have a printable name")?;
let stdout_expected = wasm_file_dir.join(format!("{}.stdout.expected", benchmark_name));
let stderr_expected = wasm_file_dir.join(format!("{}.stderr.expected", benchmark_name));
let mut stdout_expected = wasm_file_dir.join(format!("{}.stdout.expected", benchmark_name));
if !stdout_expected.exists() {
stdout_expected = wasm_file_dir.join(format!("{}.stdout.expected", "default"));
jlb6740 marked this conversation as resolved.
Show resolved Hide resolved
}
let mut stderr_expected = wasm_file_dir.join(format!("{}.stderr.expected", benchmark_name));
if !stderr_expected.exists() {
stderr_expected = wasm_file_dir.join(format!("{}.stderr.expected", "default"));
jlb6740 marked this conversation as resolved.
Show resolved Hide resolved
}

compare_output_file(wasm_file, stdout, &stdout_expected)?;
compare_output_file(wasm_file, stderr, &stderr_expected)?;
Expand Down
Loading