Add a feature for disabling GC types #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for a new wasm feature named `WasmFeatures::GC_TYPES`. This does not correspond to any upstream proposal and is intended for use in Wasmtime for disabling the runtime garbage collector at compile time. This serves as a finer-grained switch to disable the runtime dependency at validation time on a garbage collector without disabling all the features that were added in other proposals. For example the `reference-types` proposal also added support for multi-table which disabling a runtime garbage collector doesn't need to disable.
|
This is additionally borne out of discussion on WebAssembly/tool-conventions#233 where this seems like the best way forward for the "no gc at compile time" mode for Wasmtime. |
pchickey
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for a new wasm feature named
WasmFeatures::GC_TYPES. This does not correspond to any upstream proposal and is intended for use in Wasmtime for disabling the runtime garbage collector at compile time. This serves as a finer-grained switch to disable the runtime dependency at validation time on a garbage collector without disabling all the features that were added in other proposals. For example thereference-typesproposal also added support for multi-table which disabling a runtime garbage collector doesn't need to disable.