-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker compose setup #215
base: main
Are you sure you want to change the base?
Docker compose setup #215
Conversation
Thanks for the PR! I'm personally a bit hesitant to add this sort of automation without any testing of it. I'm also wary of Could this perhaps be tackled from a different angle where a |
Not saying that is the only way. The PR is more of a proposal to somehow solve "works on my machine problem". Makefile does not help with the "works on my machine thing" only it makes commands shorter. Getting back to "works on my machine". At first I tried to setup the project locally, but installing rust on windows appeared to be too combursum. Might be my lack of experience/patience, but still - would be nice to have easier setup even without knowing much about Rust since the project has to convince Python developers to use it(my subjective opinion), and we are accustomed to easy setups :D But if we would find a way to make easy windows local setups without docker would be even nicer. WSL2 disc read time is insianly slow, unless you specifically use WSL paths and not paths mounted on windows directories which is ususally not the case. |
No I agree with much of what you say, I don't think that this should necessarily require Rust. My point was moreso I'd prefer to lift the need for needing this sort of configuration entirely. For example if the project is confusing enough to warrant a docker-compose.yml file I think it's best to fix the confusion rather than adding the configuration. This isn't intended to be a complicated Python package, the main weird part is the Rust support for component compiled to wasm. Put another way, I think and alternative source to solving the difficulties you're having would be to check in a version of the Rust wasm binary into this repository (along with generated code it generates). That way it's not necessary to use |
I tried to play with test locally and... Setup is kind of complicated, did not have rust installed, maybe lack of experience with rust tools (I am a python developer first), but - it did not work on my maschine :( Therefore created some rudimentary docker-compose/make setup (instalation steps more or less copied from github actions - minus the cache). Which - works on my machine (windows 11 with WSL2), should be all fine with Linux too.