Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BitSail][Connector] Migrate rocketmq Sink connector to V1 interface #457

Merged
merged 11 commits into from
Mar 27, 2023
Merged

[BitSail][Connector] Migrate rocketmq Sink connector to V1 interface #457

merged 11 commits into from
Mar 27, 2023

Conversation

beyond-up
Copy link
Contributor

@beyond-up beyond-up commented Mar 15, 2023 •
edited
Loading

Prepare a Pull Request

Motivation

Migrate rocketmq Sink connector to V1 interface and use BitSail unified streaming and batching interface

Modifications

Describe the modifications you've done.

Verifying this change

Please pick either of the following options.

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests, example:)

    • com.bytedance.bitsail.core.EngineTest#testRunEngine

  • This change added tests and can be verified as follows:

    (example:)

    • Added unit tests for parsing of configs
    • Optimized integration tests for recovery after task failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@beyond-up beyond-up marked this pull request as ready for review March 16, 2023 04:18
@beyond-up beyond-up changed the title init RocketMQ sink v1 RocketMQ sink v1 Mar 16, 2023
@liuxiaocs7
Copy link
Contributor

liuxiaocs7 commented Mar 16, 2023 •
edited
Loading

Hi, @beyond-up , some suggestions:

@beyond-up beyond-up changed the title RocketMQ sink v1 [BitSail][Connector] Migrate rocketmq Sink connector to V1 interface #457 Mar 16, 2023
@beyond-up beyond-up changed the title [BitSail][Connector] Migrate rocketmq Sink connector to V1 interface #457 [BitSail][Connector] Migrate rocketmq Sink connector to V1 interface Mar 16, 2023
@beyond-up
Copy link
Contributor Author

Hi, @beyond-up , some suggestions:

ok, thx!

@beyond-up beyond-up marked this pull request as draft March 16, 2023 09:38
@beyond-up beyond-up marked this pull request as ready for review March 20, 2023 04:06
@beyond-up
Copy link
Contributor Author

beyond-up commented Mar 20, 2023 •
edited
Loading

Hi, @beyond-up , some suggestions:

I have modified, please help me review the code, thx @liuxiaocs7

garyli1019
garyli1019 reviewed Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@garyli1019 garyli1019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beyond-up thanks for your contribution, overall looks good. Left some minor comments

@beyond-up
Copy link
Contributor Author

Thanks for you suggestions, I hava optimized my code ,please help me review the code ! @garyli1019

@beyond-up beyond-up requested a review from garyli1019 March 22, 2023 10:08
@beyond-up beyond-up requested a review from garyli1019 March 27, 2023 02:51
garyli1019
garyli1019 approved these changes Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@garyli1019 garyli1019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution! @beyond-up

@garyli1019 garyli1019 merged commit dbecb2f into bytedance:master Mar 27, 2023
@beyond-up beyond-up deleted the rocketmq_sink_v1 branch March 27, 2023 09:45
hk-lrzy pushed a commit that referenced this pull request May 24, 2023
@beyond-up @garyli1019
[BitSail][Connector] Migrate rocketmq Sink connector to V1 interface (#…
befa8c7 
…457)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyli1019 garyli1019 garyli1019 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BitSail][Connector] Migrate rocketmq Sink connector to V1 interface
3 participants
@beyond-up @liuxiaocs7 @garyli1019