Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix an error in CI #302

Merged
merged 2 commits into from
Sep 15, 2024
Merged

fix: fix an error in CI #302

merged 2 commits into from
Sep 15, 2024

Conversation

Lzzzzzt
Copy link
Collaborator

@Lzzzzzt Lzzzzzt commented Sep 15, 2024

Find and fix a bug in CI:

When CHANNEL is nightly, this will happen

+ [ nightly == nightly ]
.github/workflows/ci.sh: 42: [: nightly: unexpected operator

This bug is found because #300 pass all the CI test but failed in code-coverage.

This PR fix this bug, and also fix the error in code-coverage

Signed-off-by: lzzzt <[email protected]>
.github/workflows/ci.sh: 42: [: nightly: unexpected operator

Signed-off-by: lzzzt <[email protected]>

fix: fix an error in tests/fs_symlink.rs

Signed-off-by: lzzzt <[email protected]>
Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit bb873b0 into bytedance:master Sep 15, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants