Enable non-standard OpenBLAS extensions #1571
Conversation
We introduce openblas_full, as an alternative to openblas, and load the extra functions there.
openblas_full is an alternative to openblas that doesn't skip any function provided by openblas, except deprecated functions. It includes functions that are not present in Accelerate and/or MKL, but are included in OpenBLAS as an useful addition to the netlib BLAS interface.
... and just redefines map().
openblas/src/main/java/org/bytedeco/openblas/presets/openblas_full.java
Outdated
Show resolved
Hide resolved
openblas/src/main/java/org/bytedeco/openblas/presets/openblas_full.java
Outdated
Show resolved
Hide resolved
|
Is this ready to go now? |
|
It seems that the refactoring to functionsToSkip() did not work as intended. Looking at the code, Java-wise, I can't see why openblas_full is not getting an empty string array to skip, but JavaCPP-wise, there might be a gotcha. Is this worth pursuing, or should we revert to the first solution that repeats some code? (but who knows, maybe the same gotcha is relevant there?) BTW, the openblas_full class repeats the methods that are already in the openblas class. I'm not sure is that the JavaCPP generator is supposed to do that when properly configured (judging by the openblas_nolapack and openblas, it is not...). |
|
Right, the InfoMap gets filled already via inherit... |
|
So, if we just removed the inherit value in the annotation, the result will be that openblas_full reuses the Java code, while being configured from scratch, independently from openblas_nolapack and openblas? It won't mess up some fragile mechanism that's supposed to weed out repetitions, take care of overrides and such? |
|
It's not as simple as that I'm sure, but someone has to try it. Do whatever it takes to make it work like you want it, that's fine! |
|
Sure. Being a total noob, I would just like some pointers what would likely work, and what wouldn't, to avoid poking in the dark :) |
|
Actually, there's already a pattern like that here where a static mapCommon() method does the trick: |
|
Thanks. Will check it out and experiment (offline this time :) |
This contribution enables the operations that are present in OpenBLAS, but might not be directly supported by Accelerate and/or MKL. The previous behavior is preserved, and the new openblas_full class added, which extends the openblas class and enables the "extra" operations.