-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced C++ -> Java mapping #798
Open
Avdiji
wants to merge
27
commits into
bytedeco:master
Choose a base branch
from
Seclous:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/nvd exception handling
… files into a single linked library instead of multiple different ones
Would it be possible to split these changes into 4 or 5 smaller pull requests? Also please revert any unnecessary changes in formatting |
Sure thing! I'll get to it once i find the time |
No need to do all of them at once, just a first small pull request that stands alone, and then when that gets merged, another small pull request based on the first set of changes, etc. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added serveral functionalities which enable the user to map more advanced and specific edgecases.
Here's a list of all the additional features:
Custom Exception-Mapping
Custom JNI-Code in the beggining of each generated JNI-File
Custom JNI-Mapping of individual java methods
Added several properties to the Virtual annotation, in order to enable Cross-Language Polymorphism for custom mapped datatypes.
Added setClassLoader function, which ensures a ClassLoader at everytime (using it is optional though).
Overall the changes are supposed to allow the user to map C++ code in a more specific way and gives more freedom to add custom JNI-Code.