Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to protobuf 0.6.3 #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rockneurotiko
Copy link
Contributor

Protobuf 0.5.3 is really old, I think it's good to at least provide a version with 0.6.3 (and probably with 0.7.1 too).

The main change is that now the family_name (StringValue) and the qualifier (BytesValue) doesn't arrives just with the value, it arrives with the original struct {value: X}

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #21   +/-   ##
======================================
  Coverage    92.2%   92.2%           
======================================
  Files          20      20           
  Lines         308     308           
======================================
  Hits          284     284           
  Misses         24      24
Impacted Files Coverage Δ
lib/data/chunk_reader.ex 97.22% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215b104...217e3aa. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant