-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user category icons next to the contributor link #2073
base: master
Are you sure you want to change the base?
Conversation
@brunobesson What do you mean? |
I was proposing to choose one of these icons to highlight such users. |
|
We have quite a few user categories
Do we intend to have an icon for each of them? I guess not for amateur. Maybe we should stick to something like we only use one icon (with some kind of order of precedence, even if often, we wouldn't have collisions, e.g. it would be weird to be mountain_guide + club) I would propose something like:
Or maybe it would be simpler to have one group "any kind of mountain professional" and one group "club or institution" As an aside, "mountain leader" is translated as "ouvreur" in french, is that correct?? |
@lbesson Good questions! I have to admit I am mostly interested by the "mountain guide" category, even though it would definitely be interesting to identify the other categories as well. I am a bit concerned it's going to be a bit awkward to set an icon for every category. For guides we could reuse the UIAGM logo despite I don't know if it is really readable when shrunk small enough to fit in a text line...
Nope, the french words are "accompagnateur en moyenne montagne". |
Having an icon only for mountain guides guides could trigger quite a lot of discussions in the community :) |
Hi, I suggest the following icons, based on @lbesson partition:
I suggest the certificat faicon , as shields are already used for moderators and crowns might raise criticism.
I would use the snow-flake faicon, obviously.
I would use the users faicon, at least for clubs. |
Hey @AntoineMarnat I am a bit reluctant though to group several user categories with the same icon. For me it's definitely not the same to read the snow reports from a mountain guide than from a climbing instructor. |
OK, let me suggest a more detailed selection then:
-> create icons from the activity icons
Icon I create in #2349 (similar to https://assets.avalanche.ca/images/early_season_icon.svg)
|
I created the missing icons here: https://github.com/c2corg/c2c_ui/tree/AntoineMarnat-patch-2/src/assets/font-awesome-custom/svg/miscs |
Up, should we discuss the icons ? |
@AntoineMarnat Thanks for your proposals! My concern is they might not be explicit enough. For instance I don't think it is obvious that a hiker icon means "mountain leader", neither a alpinist icon means "mountain guide". |
That would be interesting to make contributors categories (guides, instructors, hut keepers, avalanche_forecaster, etc.) more explicit especially in outings. For instance by adding a small icon next to the contributor names.
I don't really know how to do it yet and would appreciate any input :P
I have thought of adding classes to the contributor links and having CSS selectors such as:
Would this make sense?

Should this use png icons? SVG icons?
The suggested change seems to only impact the contributor links in the outings (not in the versions pages nor in the route pages nor in the cards nor in outings lists etc.).