Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user category icons next to the contributor link #2073

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asaunier
Copy link
Member

@asaunier asaunier commented Jul 8, 2021

That would be interesting to make contributors categories (guides, instructors, hut keepers, avalanche_forecaster, etc.) more explicit especially in outings. For instance by adding a small icon next to the contributor names.

I don't really know how to do it yet and would appreciate any input :P

I have thought of adding classes to the contributor links and having CSS selectors such as:

mountain_guide:after {
  content: url('some_icon_lnk');
}

Would this make sense?
Should this use png icons? SVG icons?
The suggested change seems to only impact the contributor links in the outings (not in the versions pages nor in the route pages nor in the cards nor in outings lists etc.).
Screenshot from 2021-07-08 22-08-06

@asaunier asaunier added enhancement New feature or request help wanted Extra attention is needed labels Jul 8, 2021
@brunobesson
Copy link
Member

image
?

@asaunier
Copy link
Member Author

asaunier commented Jul 8, 2021

@brunobesson What do you mean?

@brunobesson
Copy link
Member

I was proposing to choose one of these icons to highlight such users.

@cbeauchesne
Copy link
Member

cbeauchesne commented Jul 9, 2021

@lbesson
Copy link
Member

lbesson commented Jul 16, 2021

We have quite a few user categories

      "mountain_guide",
      "mountain_leader",
      "ski_instructor",
      "climbing_instructor",
      "mountainbike_instructor",
      "paragliding_instructor",
      "hut_warden",
      "ski_patroller",
      "avalanche_forecaster",
      "club",
      "institution"

Do we intend to have an icon for each of them? I guess not for amateur.
I also think that a user can have more than one category.

Maybe we should stick to something like we only use one icon (with some kind of order of precedence, even if often, we wouldn't have collisions, e.g. it would be weird to be mountain_guide + club)

I would propose something like:

  1. Professional guides (mountain_guide, instructors, ...) with some kind of shield badge
  2. Avalanche professionals (avalanche_forecaster + ski_patroller)
  3. Hut warden
  4. Club + institution

Or maybe it would be simpler to have one group "any kind of mountain professional" and one group "club or institution"

As an aside, "mountain leader" is translated as "ouvreur" in french, is that correct??

@asaunier
Copy link
Member Author

@lbesson Good questions!

I have to admit I am mostly interested by the "mountain guide" category, even though it would definitely be interesting to identify the other categories as well.

I am a bit concerned it's going to be a bit awkward to set an icon for every category. For guides we could reuse the UIAGM logo despite I don't know if it is really readable when shrunk small enough to fit in a text line...

As an aside, "mountain leader" is translated as "ouvreur" in french, is that correct??

Nope, the french words are "accompagnateur en moyenne montagne".

@lbesson
Copy link
Member

lbesson commented Jul 17, 2021

Having an icon only for mountain guides guides could trigger quite a lot of discussions in the community :)

@AntoineMarnat
Copy link
Collaborator

Hi,

I suggest the following icons, based on @lbesson partition:

  1. Professional/Instructors
      "mountain_guide",
      "mountain_leader",
      "ski_instructor",
      "climbing_instructor",
      "mountainbike_instructor",
      "paragliding_instructor",

I suggest the certificat faicon , as shields are already used for moderators and crowns might raise criticism.

  1. Avalanche professionals (avalanche_forecaster + ski_patroller)
      "ski_patroller",
      "avalanche_forecaster",

I would use the snow-flake faicon, obviously.

  1. Hut warden
    "hut_warden",
    I suggest the house-user faicon.
  2. Club/institution
        "club",
      "institution"

I would use the users faicon, at least for clubs.

@asaunier
Copy link
Member Author

Hey @AntoineMarnat
Thanks for the nice icons, especially since they are still readable at small size.

I am a bit reluctant though to group several user categories with the same icon. For me it's definitely not the same to read the snow reports from a mountain guide than from a climbing instructor.
In v5 there were already grouped categories such as "professionel de l'encadrement", that was totally useless.
In my opinion we need to find dedicated icons for every single user category.

@AntoineMarnat
Copy link
Collaborator

OK, let me suggest a more detailed selection then:

1. Professional/Instructors
  "mountain_guide",
  "mountain_leader",

fa-hiking

  "ski_instructor",

fa-skiing-nordic

  "climbing_instructor",
  "mountainbike_instructor",
  "paragliding_instructor",

-> create icons from the activity icons

2. Avalanche professionals
  "ski_patroller",

fa-snowflake)

  "avalanche_forecaster",

Icon I create in #2349 (similar to https://assets.avalanche.ca/images/early_season_icon.svg)

3. Hut warden
   ` "hut_warden",`

fa-house-user.

4. Club/institution
    "club",

fa-users

  "institution"

fa-university

@AntoineMarnat
Copy link
Collaborator

@AntoineMarnat
Copy link
Collaborator

Up, should we discuss the icons ?

@asaunier
Copy link
Member Author

@AntoineMarnat Thanks for your proposals! My concern is they might not be explicit enough. For instance I don't think it is obvious that a hiker icon means "mountain leader", neither a alpinist icon means "mountain guide".
Perhaps we should call for suggestions in the forum?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants